OJ Kwon
OJ Kwon
> A plugin can rely on mapping a Span to the LineCol when the Span is not at BytePos(0) Yes, that's my understanding as well. > This would be the...
@ijjk mind share how to set dependencies for the test? for some reason newly added test fails with ``` Can't resolve '@mdx-js/react' ``` while previous mdx test passes with same...
@ijjk ok, test now seems passing but 2 q I couldn't answer: 1. https://github.com/vercel/next.js/pull/41919/files#r1012398317 2. Not sure why precompiled packages updated?
> It looks like it is passing correctly is CI now, is this still an issue locally? No, it passes local and CI both by having correct transitive deps. Q...
Just got build result from next-swc, good to go.
> Could we show a diff to the expected output? That's I'm planning to do after land this change.
This seems due to new appdir adds dev overlay installs hmr socket (https://github.com/vercel/next.js/blob/9bf811eea0028dcc4f74070e8a98c5d11da97d41/packages/next/client/components/react-dev-overlay/internal/helpers/use-websocket.ts#L25) We'll probably need to update dev overlay to aware --turbo to suppress connection / or disable overlay...
https://github.com/kwonoj/swc-plugin-coverage-instrument/issues/183#issuecomment-1305880772 I did a quick try and looks like this is not a next.js upstream bug, more of a bug in the plugin. Probably, this issue can be closed.
@sokra so https://github.com/vercel/turbo/pull/2552 is not relevant and should be closed?