docker-registry-frontend icon indicating copy to clipboard operation
docker-registry-frontend copied to clipboard

Published 20 hours ago • verified publisher icon kwk

Extend #84

Open Filirom1 opened this issue 9 years ago • 10 comments

Hello,

I merged #84 and #96, fixed some bugs, re-add the size feature, and add a tab to generate the Dockerfile from the manifest.

This project rocks ! thanks @kwk @arthurdk @bjoernHeneka

Cheers Romain

Filirom1 avatar Feb 11 '16 21:02 Filirom1

@Filirom1 Thank you for the work. I just have concerns regarding the layer size which is kind of broken with some images (maybe with big ones but not so sure). I'll try to reproduce asap and let you know.

arthurdk avatar Feb 11 '16 22:02 arthurdk

I will try it today on production registries. I will see if I can reproduce the layer size issue.

Filirom1 avatar Feb 12 '16 07:02 Filirom1

It works quite well !

I have big images:

Size (including base image sizes)
1,405.97 MB

Filirom1 avatar Feb 12 '16 10:02 Filirom1

@Filirom1 It's good to know big images are not the problem. Which browser did you try it with ? I'll look into it this evening to find out if the problem come from my setup.

arthurdk avatar Feb 12 '16 13:02 arthurdk

Firefox 44.0.1 Chrome 48.0.2564.109 m

Filirom1 avatar Feb 12 '16 13:02 Filirom1

@Filirom1 So I've tested the size feature and it seems to work well. As there was only minor changes since I've implemented it was probably a side effect due to something else... (old version of browser? I don't know). Anyway its good to have it back.

arthurdk avatar Feb 15 '16 15:02 arthurdk

Great !

Filirom1 avatar Feb 15 '16 15:02 Filirom1

Please be patient a bit longer. I'm just coming back to my beloved project...

kwk avatar Mar 22 '16 14:03 kwk

I rebased this PR.

Filirom1 avatar Apr 11 '16 08:04 Filirom1

Any updates? This PR looks fine! Thanks guys!

HadesArchitect avatar May 11 '16 13:05 HadesArchitect