KVIrc icon indicating copy to clipboard operation
KVIrc copied to clipboard

Published 20 hours ago • verified publisher icon kvirc

roboirc's PR and modifications

Open roboirc opened this issue 5 years ago • 17 comments

roboirc avatar Nov 10 '19 14:11 roboirc

What's the purpose of this pull request? What changes are you proposing?

AndrioCelos avatar Nov 10 '19 14:11 AndrioCelos

The purpose of this pull request is to include better tool tips within KVIrc. I am hoping to improve the tool tips in KVIrc so the software's features are clearer for others via tool tips.

roboirc avatar Nov 10 '19 15:11 roboirc

The only change I like is the one in KviIrcView.cpp

wodim avatar Nov 10 '19 15:11 wodim

Ok. Hopefully more coming in future.

roboirc avatar Nov 10 '19 15:11 roboirc

How does PR work? Who includes these changes if they are accepted?

roboirc avatar Nov 11 '19 08:11 roboirc

The commit messages need a better description

DarthGandalf avatar Nov 13 '19 12:11 DarthGandalf

What did the check fail on? Travis CI?

roboirc avatar Nov 18 '19 13:11 roboirc

Looks like it failed because a job failed to start on Travis. I've just restarted it and it worked: https://travis-ci.org/kvirc/KVIrc/jobs/612232346 Please have a look at other devs' comments

ctrlaltca avatar Nov 18 '19 14:11 ctrlaltca

Thanks will do.

roboirc avatar Nov 18 '19 14:11 roboirc

Now tooltip for icons in Icon Table shows name of icon which is important when using them. Before that info was not visible.

roboirc avatar Nov 27 '19 05:11 roboirc

@ctrlaltca how come CI is failing again?

roboirc avatar Nov 27 '19 09:11 roboirc

Somethign about perl support on windows, unrelated to your change.

ctrlaltca avatar Nov 27 '19 13:11 ctrlaltca

Ok cool. How come it shows X next to ac9f957? The change has not yet been accepted or failed CI again or what?

roboirc avatar Nov 27 '19 16:11 roboirc

Updating PR with more changes as follows. All changes by me are indicated by my nickname in comments:

  • Increased size of icons in Icon Manager with centered window
  • Before the option KviOption_boolCommandlineInUserFriendlyModeByDefault did not work properly, now it either enables or disables the friendly mode based on the option in menu.
  • You can open destination folder for downloaded files via right click popup menu on the item.
  • Colour tint on filename after right clicking on a downloaded file has been removed as it makes filename hard to see.

To download specific commits look under Commits tab in this git. And on the right side you can click on the <> symbol to download that specific git.

roboirc avatar Dec 01 '19 14:12 roboirc

  1. Please remove the cmake build artifacts
  2. Please remove the autogenerated docs
  3. Please remove your IDE's config stuff

I can't even look at the proper changes since GitHub truncates the files changed. It appears that the intent of this PR involves changes that are unrelated to each other, so perhaps you could open a PR for each feature/bug/enchangement fix you are proposing.

staticfox avatar Dec 02 '19 03:12 staticfox

@staticfox By 2, you mean the KVIrc/doc folder?

roboirc avatar Dec 02 '19 04:12 roboirc

How do I update this PR with latest changes? I am unable to update this PR any more. Thanks.

roboirc avatar Feb 08 '20 06:02 roboirc

I'm sorry but i have to close this PR. It's just impossible to be reviewed.

ctrlaltca avatar Jul 08 '23 18:07 ctrlaltca