ktransformers icon indicating copy to clipboard operation
ktransformers copied to clipboard

[feat](moe_kernel): add amd blis support (int8)

Open KMSorSMS opened this issue 2 weeks ago • 4 comments

#1582 #1601

KMSorSMS avatar Nov 12 '25 03:11 KMSorSMS

Summary of Changes

Hello @KMSorSMS, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the project's hardware support by integrating AMD BLIS for optimized Mixture of Experts (MoE) kernel operations. It introduces new INT4 and INT8 quantized MoE kernel implementations and refines the build system to provide better configurability and a more robust developer experience, particularly for CUDA-enabled builds.

Highlights

  • AMD BLIS Support: Introduced a new CMake preset named 'amd' and configured specific flags (KTRANSFORMERS_CPU_MOE_AMD, KTRANSFORMERS_CPU_MOE_KERNEL) to enable AMD BLIS for Mixture of Experts (MoE) kernels, enhancing performance on AMD platforms.
  • New MoE Kernel Implementations: Integrated Int4_KERNEL_MOE and Int8_KERNEL_MOE classes into the Python KTMoEWrapper, allowing for efficient MoE operations with INT4 and INT8 quantization, likely leveraging the new AMD BLIS backend.
  • Build System Enhancements: Improved the setup.py script by adding automatic nvcc path detection, support for specifying CUDA architectures via CPUINFER_CUDA_ARCHS, and an option (CPUINFER_ALWAYS_CLEAN) to clean the build directory before configuration, streamlining the compilation process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 12 '25 03:11 gemini-code-assist[bot]