Mooncake icon indicating copy to clipboard operation
Mooncake copied to clipboard

add heterogeneous-tcp

Open AscendTransport opened this issue 6 days ago • 1 comments

Description

Type of Change

  • Types
    • [ ] Bug fix
    • [ ] New feature
      • [x] Transfer Engine
      • [ ] Mooncake Store
      • [ ] Mooncake EP
      • [ ] Integration
      • [ ] P2P Store
      • [ ] Python Wheel
    • [ ] Breaking change
    • [ ] CI/CD
    • [ ] Documentation update
    • [ ] Other

How Has This Been Tested?

Checklist

  • [x] I have performed a self-review of my own code.
  • [x] I have updated the documentation.
  • [x] I have added tests to prove my changes are effective.

AscendTransport avatar Nov 27 '25 07:11 AscendTransport

Summary of Changes

Hello @AscendTransport, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the mooncake transfer engine by introducing a new HeterogeneousTcpTransport layer. This addition enables efficient data transfer between Ascend NPUs and GPUs over TCP, complementing existing transport methods. The changes involve updating the build configuration, integrating the new transport into the multi-transport system, and implementing the necessary memory management and transfer logic for the TCP-based heterogeneous communication.

Highlights

  • New Heterogeneous TCP Transport: Introduced HeterogeneousTcpTransport to facilitate data transfer between Ascend NPUs and GPUs using TCP.
  • Build System Integration: Added a new CMake option USE_ASCEND_HETEROGENEOUS_TCP and integrated it into the build system for conditional compilation and linking.
  • Transfer Engine Updates: Modified the core TransferEngine and MultiTransport components to recognize and utilize the new TCP-based heterogeneous transport.
  • Memory Management for Transfers: Implemented mechanisms within HeterogeneousTcpTransport for managing host and device memory, including asynchronous memory copies, to optimize data movement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 27 '25 07:11 gemini-code-assist[bot]