katalyst-core icon indicating copy to clipboard operation
katalyst-core copied to clipboard

enhance(advisor): power cap service supports GetAdvice

Open h-w-chen opened this issue 7 months ago • 1 comments

What type of PR is this?

Enhancements - power cap advisor supports GetAdvice unary GRPC protocol, with long polling ability

What this PR does / why we need it:

This PR implements GetAdvice method of new advisor-qrm communication protocol. To avoid communication overhead, it leverages long-polling so as to reduce the client requests resulting empty responses.

h-w-chen avatar Apr 21 '25 20:04 h-w-chen

Codecov Report

Attention: Patch coverage is 92.04545% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.91%. Comparing base (a0b161a) to head (9ae1338). Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
...advisor/plugin/poweraware/capper/server/service.go 89.06% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   60.78%   60.91%   +0.13%     
==========================================
  Files         613      613              
  Lines       64787    64917     +130     
==========================================
+ Hits        39378    39546     +168     
+ Misses      21426    21384      -42     
- Partials     3983     3987       +4     
Flag Coverage Δ
unittest 60.91% <92.04%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 21 '25 20:04 codecov[bot]