katalyst-core icon indicating copy to clipboard operation
katalyst-core copied to clipboard

feat(*): add a reallocate tag to the MetricNameAllocateFailed metric

Open JulyWindK opened this issue 7 months ago • 2 comments

What type of PR is this?

Observation metric enhancement

What this PR does / why we need it:

When resource allocation fails, it indicates whether it is the first allocation or reallocation.

Which issue(s) this PR fixes:

Add reallocated tag to katalyst.alloc_failed metric

Special notes for your reviewer:

JulyWindK avatar Apr 17 '25 11:04 JulyWindK

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 17 '25 11:04 CLAassistant

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (492c444) to head (98d43b8). Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 20.00% 8 Missing :warning:
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 70.00% 2 Missing and 1 partial :warning:
...g/agent/qrm-plugins/network/staticpolicy/policy.go 66.66% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   61.05%   61.08%   +0.03%     
==========================================
  Files         614      614              
  Lines       64993    65019      +26     
==========================================
+ Hits        39679    39720      +41     
+ Misses      21319    21306      -13     
+ Partials     3995     3993       -2     
Flag Coverage Δ
unittest 61.08% <57.57%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 17 '25 11:04 codecov[bot]