ssp-operator icon indicating copy to clipboard operation
ssp-operator copied to clipboard

Remove node from cnv:vmi_status_running:count

Open sradco opened this issue 4 weeks ago • 8 comments

What this PR does / why we need it: The cnv:vmi_status_running:count recording rule should not include the node label.

This PR removes it from the recording rule.

Which issue(s) this PR fixes:

Fixes #https://issues.redhat.com/browse/CNV-72167

Special notes for your reviewer:

Release note:

NONE

sradco avatar Nov 09 '25 12:11 sradco

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot avatar Nov 09 '25 12:11 kubevirt-bot

@avlitman @machadovilaca please review this pr

sradco avatar Nov 09 '25 12:11 sradco

/lgtm

avlitman avatar Nov 10 '25 10:11 avlitman

/retest-required

jcanocan avatar Nov 10 '25 11:11 jcanocan

Hi @0xFelix can you please review this pr?

sradco avatar Nov 10 '25 11:11 sradco

@sradco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images c2a490d701122702a0a7d7573698b676cd9c4e34 link true /test images
ci/prow/unittests c2a490d701122702a0a7d7573698b676cd9c4e34 link true /test unittests
ci/prow/e2e-single-node-functests c2a490d701122702a0a7d7573698b676cd9c4e34 link true /test e2e-single-node-functests
ci/prow/e2e-upgrade-functests c2a490d701122702a0a7d7573698b676cd9c4e34 link true /test e2e-upgrade-functests
ci/prow/e2e-functests c2a490d701122702a0a7d7573698b676cd9c4e34 link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 10 '25 15:11 openshift-ci[bot]

Pull requests that are marked with lgtm should receive a review from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

kubevirt-bot avatar Nov 17 '25 16:11 kubevirt-bot