kubevirt-tekton-tasks
kubevirt-tekton-tasks copied to clipboard
add multiarch support for kubevirt tasks
What this PR does / why we need it: As of now Tekton kubevirt tasks supported only on x86/amd64. so this PR will add support for s390x, arm64 cpu platforms.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE
Hi @Basavaraju-G. Thanks for your PR.
I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi @ksimon1 would you please review this PR?
Your commit looks to be mangled (author, message). Can you please correct that?
fixed
@Basavaraju-G are you planning to add test runners for e2e tests on s390x?
@Basavaraju-G are you planning to add test runners for e2e tests on s390x?
@ksimon1 yes we have it in planning. we have some kubevirt projects in https://prow.ci.kubevirt.io/ are running s390x e2e jobs in here https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirtci-s390x/1902662300989394944.
@Basavaraju-G I tried to trigger it locally and it is failing on:
[linux/s390x] [2/2] STEP 3/10: RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all
container exited on segmentation fault
Error: 2 errors occurred:
* [linux/arm64]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1
* [linux/s390x]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1
@Basavaraju-G I tried to trigger it locally and it is failing on:
[linux/s390x] [2/2] STEP 3/10: RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all container exited on segmentation fault Error: 2 errors occurred: * [linux/arm64]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1 * [linux/s390x]: building at STEP "RUN dnf install -y xorriso openssh-clients nbdkit nbdkit-curl-plugin qemu-img && dnf clean all": while running runtime: exit status 1
HI @ksimon1 may i know what version of podman your using it? and may i know which OS are you building on it(RHEL/Ubuntu)? i was able to build with github actions job. build log here https://github.com/Basavaraju-G/kubevirt-tekton-tasks/actions/runs/13896150271/job/38877127084.
/retest
/test e2e-tests
@Basavaraju-G: No presubmit jobs available for kubevirt/kubevirt-tekton-tasks@main
In response to this:
/test e2e-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ksimon1
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ksimon1]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 0xFelix, Basavaraju-G, ksimon1
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [0xFelix,ksimon1]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment