Upgrade operator-observability package and remove deprecated functions

[machadovilaca]

What this PR does / why we need it:

#3144 needs an upgrade to the operator-observability package, which deprecates some functions used by HCO. If we keep using those functions golangci throws an error on the CI pipelines. This PR upgrades the package and implements the new approach it suggests.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

• [ ] PR Message
• [ ] Commit Messages
• [ ] How to test
• [ ] Unit Tests
• [ ] Functional Tests
• [ ] User Documentation
• [ ] Developer Documentation
• [ ] Upgrade Scenario
• [ ] Uninstallation Scenario
• [ ] Backward Compatibility
• [ ] Troubleshooting Friendly

Jira Ticket:

-

Release note:

none

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coveralls]

Pull Request Test Coverage Report for Build 11575589529

Details

• 8 of 9 (88.89%) changed or added relevant lines in 3 files are covered.
• 3 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 72.47%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/monitoring/rules/rules.go	4	5	80.0%
<!--	Total:	8	9

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	3	86.14%
<!--	Total:	3

Totals
Change from base Build 11570123551:	-0.02%
Covered Lines:	6044
Relevant Lines:	8340

---

💛 - Coveralls

[hco-bot]

hco-e2e-operator-sdk-gcp lane succeeded. /override ci/prow/hco-e2e-operator-sdk-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure

In response to this:

hco-e2e-operator-sdk-gcp lane succeeded. /override ci/prow/hco-e2e-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hco-bot]

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

In response to this:

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hco-bot]

hco-e2e-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-aws

In response to this:

hco-e2e-operator-sdk-sno-azure lane succeeded. /override ci/prow/hco-e2e-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hco-bot]

hco-e2e-operator-sdk-gcp lane succeeded. /override ci/prow/hco-e2e-operator-sdk-aws

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws

In response to this:

hco-e2e-operator-sdk-gcp lane succeeded. /override ci/prow/hco-e2e-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci[bot]]

@machadovilaca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-operator-sdk-azure	c832e2f6347bb156366a50b56179e66077dfa7cb	link	true	/test hco-e2e-operator-sdk-azure
ci/prow/hco-e2e-operator-sdk-sno-aws	c832e2f6347bb156366a50b56179e66077dfa7cb	link	false	/test hco-e2e-operator-sdk-sno-aws
ci/prow/hco-e2e-operator-sdk-aws	c832e2f6347bb156366a50b56179e66077dfa7cb	link	true	/test hco-e2e-operator-sdk-aws
ci/prow/hco-e2e-kv-smoke-azure	c832e2f6347bb156366a50b56179e66077dfa7cb	link	true	/test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hco-bot]

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[avlitman]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avlitman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [avlitman]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment