Add HCO API to set CDIConfig DataVolumeTTLSeconds

[arnongilboa]

Signed-off-by: Arnon Gilboa [email protected]

Fixes https://github.com/kubevirt/hyperconverged-cluster-operator/issues/2038

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

• [ ] PR Message
• [ ] Commit Messages
• [ ] How to test
• [ ] Unit Tests
• [ ] Functional Tests
• [ ] User Documentation
• [ ] Developer Documentation
• [ ] Upgrade Scenario
• [ ] Uninstallation Scenario
• [ ] Backward Compatibility
• [ ] Troubleshooting Friendly

Release note:

Add HCO API to set CDIConfig DataVolumeTTLSeconds

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign orenc1 for approval by writing /assign @orenc1 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[coveralls]

Pull Request Test Coverage Report for Build 2942192316

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 84.971%

---

Totals
Change from base Build 2925935809:	0.003%
Covered Lines:	4461
Relevant Lines:	5250

---

💛 - Coveralls

[hco-bot]

okd-hco-e2e-image-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-image-index-gcp

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hco-bot]

hco-e2e-image-index-aws lane succeeded. /override ci/prow/hco-e2e-image-index-gcp hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure okd-hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-gcp hco-e2e-image-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-image-index-sno-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-image-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded. /override ci/prow/hco-e2e-image-index-gcp hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure okd-hco-e2e-upgrade-index-aws lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-gcp hco-e2e-image-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-image-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hco-bot]

hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure

[kubevirt-bot]

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci[bot]]

@arnongilboa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-hco-e2e-image-index-gcp	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	true	/test okd-hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-sno-azure	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	false	/test hco-e2e-image-index-sno-azure
ci/prow/hco-e2e-kv-smoke-gcp	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	true	/test hco-e2e-kv-smoke-gcp
ci/prow/okd-hco-e2e-upgrade-index-gcp	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	true	/test okd-hco-e2e-upgrade-index-gcp
ci/prow/hco-e2e-upgrade-prev-index-azure	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	true	/test hco-e2e-upgrade-prev-index-azure
ci/prow/hco-e2e-image-index-gcp	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	true	/test hco-e2e-image-index-gcp
ci/prow/hco-e2e-upgrade-index-sno-azure	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	false	/test hco-e2e-upgrade-index-sno-azure
ci/prow/hco-e2e-kv-smoke-azure	482e852271f3d8ec44ad7d9c4e77c55707e15d99	link	true	/test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[arnongilboa]

/hold

We decided to hold it for now, as we prefer having as few CDI knobs as possible in HCO, and this seems like something that someone would disable only for debugging or if there was a bug. DataVolumeTTLSeconds is configured in the CDI CR, so we can use a jsonpatch to change it if there are extenuating circumstances.