hyperconverged-cluster-operator
hyperconverged-cluster-operator copied to clipboard
kubevirt
Expose the webhook with configured TLS config
Properly expose the the validating webhook with TLS as configured on HCO CR or at cluster level. The configuration is cached in the webhook and refreshed each time the cluster admin tries to create or refresh the HCO CR.
Test it e2e on plain k8s and OCP/OKD. Please also notice that with FIPS enabled golang builders we can get only a subset of allowed ciphers for the same TLS profile.
Signed-off-by: Simone Tiraboschi [email protected]
Reviewer Checklist
Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.
- [ ] PR Message
- [ ] Commit Messages
- [ ] How to test
- [ ] Unit Tests
- [ ] Functional Tests
- [ ] User Documentation
- [ ] Developer Documentation
- [ ] Upgrade Scenario
- [ ] Uninstallation Scenario
- [ ] Backward Compatibility
- [ ] Troubleshooting Friendly
Release note:
Expose the webhook with configured TLS config
Pull Request Test Coverage Report for Build 2998249899
- 117 of 152 (76.97%) changed or added relevant lines in 3 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.3%) to 85.271%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| controllers/webhooks/controller.go | 26 | 30 | 86.67% |
| pkg/webhooks/validator/validator.go | 84 | 115 | 73.04% |
| <!-- | Total: | 117 | 152 |
| Totals | |
|---|---|
| Change from base Build 2997768106: | 0.3% |
| Covered Lines: | 4585 |
| Relevant Lines: | 5377 |
💛 - Coveralls
okd-hco-e2e-upgrade-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-aws
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws
In response to this:
okd-hco-e2e-upgrade-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-aws
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
okd-hco-e2e-upgrade-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-aws
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws
In response to this:
okd-hco-e2e-upgrade-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-aws
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-azure
In response to this:
hco-e2e-upgrade-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-kv-smoke-azure lane succeeded. /override ci/prow/hco-e2e-kv-smoke-gcp
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp
In response to this:
hco-e2e-kv-smoke-azure lane succeeded. /override ci/prow/hco-e2e-kv-smoke-gcp
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-upgrade-prev-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws
In response to this:
hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-upgrade-prev-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-aws
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-upgrade-prev-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-aws hco-e2e-upgrade-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-aws
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws, ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws
In response to this:
hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure hco-e2e-upgrade-prev-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-aws hco-e2e-upgrade-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-index-sno-aws
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure
In response to this:
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure
In response to this:
hco-e2e-upgrade-prev-index-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-upgrade-prev-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure
In response to this:
hco-e2e-upgrade-prev-index-sno-aws lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure
In response to this:
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure
In response to this:
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
okd-hco-e2e-upgrade-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-aws
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws
In response to this:
okd-hco-e2e-upgrade-index-gcp lane succeeded. /override ci/prow/okd-hco-e2e-upgrade-index-aws
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-upgrade-prev-index-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-aws hco-e2e-image-index-gcp lane succeeded. /override ci/prow/hco-e2e-image-index-aws hco-e2e-image-index-gcp lane succeeded. /override ci/prow/hco-e2e-image-index-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-upgrade-prev-index-aws
In response to this:
hco-e2e-upgrade-prev-index-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-aws hco-e2e-image-index-gcp lane succeeded. /override ci/prow/hco-e2e-image-index-aws hco-e2e-image-index-gcp lane succeeded. /override ci/prow/hco-e2e-image-index-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure
In response to this:
hco-e2e-kv-smoke-gcp lane succeeded. /override ci/prow/hco-e2e-kv-smoke-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hco-e2e-upgrade-prev-index-sno-azure lane succeeded. /override ci/prow/hco-e2e-upgrade-prev-index-sno-aws