containerized-data-importer
containerized-data-importer copied to clipboard
kubevirt
We should replace "cdi-controller-***" with "cdi-deployment-***"
What happened:
when we deploy the cdi and we can get the result as fllows
What you expected to happen: I think we should replace "cdi-controller-" with "cdi-deployment-" and we get the controller pod.
How to reproduce it (as minimally and precisely as possible): Steps to reproduce the behavior.
Additional context: Add any other context about the problem here.
Environment:
- CDI version (use
kubectl get deployments cdi-deployment -o yaml): N/A - Kubernetes version (use
kubectl version): N/A - DV specification: N/A
- Cloud provider or hardware configuration: N/A
- OS (e.g. from /etc/os-release): N/A
- Kernel (e.g.
uname -a): N/A - Install tools: N/A
- Others: N/A
Hi @matthewei, thanks for bringing up this issue. We can have some conversation around this but we would need to delve into the reasons/arguments behind your proposal. CDI is currently functioning well, and changing this name doesn't seem a high priority, but as said, we can see what other team members think.
I agree the name is confusing; I worry that the upgrade path would need special handling (delete leftover cdi-deployment Deployment rsc)
Hi @matthewei, thanks for bringing up this issue. We can have some conversation around this but we would need to delve into the reasons/arguments behind your proposal. CDI is currently functioning well, and changing this name doesn't seem a high priority, but as said, we can see what other team members think.
As there are more and more CDI users, we should standardize the naming of CDI, and the naming should be conscious. Although the priority is not high, we should optimize it in a planned way. What do you think?
delete leftover cdi-deployment Deployment rsc)
yes, this is a challenge. But the "cdi-deployment-***" name does confuse users.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kubevirt-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/reopen I think we should update the issue with resolution before it being closed.
@ShellyKa13: Reopened this issue.
In response to this:
/reopen I think we should update the issue with resolution before it being closed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I'll add that I agree that the name is confusing and also that cdi-controller is more aligned with kubevirt naming. But that being said the implications need to be considered.
My thought haven't changed much https://github.com/kubevirt/containerized-data-importer/issues/3066#issuecomment-1892024933; I still think that introducing the extra upgrade path is quite risky so I am not very inclined to take that risk for a small benefit
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kubevirt-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.