add proposal for a process for api-reviews

[alaypatel07]

trafficstars

This adds a design document to address API change review guidelines bullet point in https://github.com/kubevirt/kubevirt/issues/8566.

At a high level, the process proposes 4 major improvements:

1. Guidelines for api-reviewers, inspired by kubernetes api-review process
2. Guidelines for new contributors for api facing changes
3. Tool/unit tests to help api-reviewers automate catching api breaking changes
4. Policy for addressing an API breakages detected and reported in a GA'ed version

[alaypatel07]

cc @rthallisey

[fabiand]

@acardace @xpivarc wdyt?

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[alaypatel07]

@dankenigsberg thanks for the review, accommodated all your suggestions!

[lyarwood]

/cc

[alaypatel07]

@stu-gott I have addressed all the suggestions, PTAL

[xpivarc]

/cc

[EdDev]

/cc

[EdDev]

/assign

[kubevirt-bot]

New changes are detected. LGTM label has been removed.

[xpivarc]

/cc @mhenriks @xpivarc

[kubevirt-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[kubevirt-bot]

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

[kubevirt-bot]

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

[kubevirt-bot]

@kubevirt-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.