ks-devops icon indicating copy to clipboard operation
ks-devops copied to clipboard

Support to disable build status notifications from Jenkins

Open LinuxSuRen opened this issue 3 years ago • 4 comments
trafficstars

https://github.com/kubesphere/ks-devops/pull/797 support to send a build status notification from ks-devops. But Jenkins will send it too. See the following screenshot

image

Firstly, it's totally not necessary to have both Jenkins and ks-devops build status links. We prefer to have ks-devops link only. So, we need to figure out a solution to disable the Jenkins build status link.

Solution A

Jenkins plugin Skip notifications trait could do that. We could add it to ks-jenkins.

Then, make githubSkipNotifications as the default trait. See also https://github.com/kubesphere/ks-devops/blob/f69d2264e742b7b55ae502443396c1281cbf0c81/pkg/client/devops/jenkins/internal/github.go#L43

/good-first-issue

LinuxSuRen avatar Aug 29 '22 07:08 LinuxSuRen

@LinuxSuRen: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

https://github.com/kubesphere/ks-devops/pull/797 support to send a build status notification from ks-devops. But Jenkins will send it too. See the following screenshot

image

Firstly, it's totally not necessary to have both Jenkins and ks-devops build status links. We prefer to have ks-devops link only. So, we need to figure out a solution to disable the Jenkins build status link.

Solution A

Jenkins plugin Skip notifications trait could do that. We could add it to ks-jenkins.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Aug 29 '22 07:08 ks-ci-bot

/assign

qiujiafei avatar Aug 29 '22 09:08 qiujiafei

image

@LinuxSuRen How do I simulate this notification?Can I get this jenkinsfile

qiujiafei avatar Aug 30 '22 02:08 qiujiafei

You could get the notification once you created a multi-branch Pipeline.

LinuxSuRen avatar Aug 30 '22 02:08 LinuxSuRen