ks-devops icon indicating copy to clipboard operation
ks-devops copied to clipboard

Improvement request: avoid using API tojson and tojenkinsfile

Open LinuxSuRen opened this issue 3 years ago • 2 comments

As you can see, the Pipeline editing feature requires the following two APIs:

  • v1alpha2/tojenkinsfile
  • v1alpha2/tojson

Those APIs will call Jenkins API as well. It will be unstable due to there is no HA solution for Jenkins.

image

Possible solution

Considering those APIs want to convert data format between JSON and Jenkinsfile. We could do it in the backend, for example, store the data in annotations, and convert it in the controller.

  • [ ] #714

/kind feature

LinuxSuRen avatar Jul 04 '22 07:07 LinuxSuRen

/assign

LinuxSuRen avatar Jul 13 '22 10:07 LinuxSuRen

v1alpha2/tojenkinsfile and v1alpha2/tojson was removed in https://github.com/kubesphere/ks-devops/pull/795

LinuxSuRen avatar Sep 21 '22 07:09 LinuxSuRen