ks-devops icon indicating copy to clipboard operation
ks-devops copied to clipboard

Published 20 hours ago • verified publisher icon kubesphere

Improve PipelineRun deletion logic

Open JohnNiang opened this issue 4 years ago • 6 comments
trafficstars

Currently, we have provided a GC CronJob in ks-devops helm charts, please see also https://github.com/kubesphere-sigs/ks-devops-helm-chart/pull/7.

But our PipelineRun controller hasn't considered that deletion situation yet. Therefore, I request to improve the PipelineRun deletion logic in PipelineRun controller.

/kind feature

JohnNiang avatar Sep 17 '21 01:09 JohnNiang

You can use the following method:

https://github.com/jenkins-zh/jenkins-client/blob/e86993b99fc4251aebd14307dc615062c3f419fa/pkg/job/job.go#L300

LinuxSuRen avatar Sep 17 '21 01:09 LinuxSuRen

Some test cases that need to consider:

  • [x] The Jenkins build records was missing when try to delete it

LinuxSuRen avatar Oct 09 '21 01:10 LinuxSuRen

I have tested it. It works well. /close

LinuxSuRen avatar Oct 12 '21 08:10 LinuxSuRen

@LinuxSuRen: Closing this issue.

In response to this:

I have tested it. It works well. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Oct 12 '21 08:10 ks-ci-bot

/reopen

chilianyi avatar Jul 28 '23 02:07 chilianyi

@chilianyi: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ks-ci-bot avatar Jul 28 '23 02:07 ks-ci-bot