website
website copied to clipboard
Replaced the deprecation-warning partial with docsy provided version-banner
This PR replaces the deprecation-warning.html partial with the Docsy provided version-banner.html partial. It further customized the partial to ensure that existing features don't get removed all the while keeping the Docsy provided styling and HTML tree. The following are the changes:
- Removed all styling from
_custom.scssthat used the now removed ids and classes related to thedeprecation-warningpartial. - Updated
_default/baseof.html,blog/baseof.html,case-studies/single-baseof.htmlanddocs/baseof.htmlto refer toversion-banner. - In the new
version-banner.html, apart from the content, which is customised for localisation, thedeprecatedparam is still used as that param is used in multiple places and can be challenging to remove all of them at the same time. Alternatively, I can change the param only here keeping all other use of thedeprecatedparam as is. - In
hugo.toml, thecurrentUrlparam is renamed tourl_latest_versionas that's the one preferred by Docsy and this param is not used anywhere else.
Issue
Closes: #50216
/area web-development
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 804388f903c854ee0e19f43a04c71f2bdcc9dd97 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67ffa01b11a9ec00074a40fa |
| Deploy Preview | https://deploy-preview-50217--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
https://deploy-preview-50217--kubernetes-io-main-staging.netlify.app/community/ looks fine, but if I locally set the site to be an older version, it doesn't look quite right to me. Could we use a <section> with a blue background there?
I was able to use a bit of CSS to make it look like before. Hope this is ok.
It's not quite right (hyperlink text should be white, on that page), but it's close enough:
/lgtm
LGTM label has been added.
Oops, I will fix it when I am doing the another pass (which I will probably need to do anyway).
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: divya-mohan0209
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [divya-mohan0209]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
This has a merge conflict, @SayakMukhopadhyay. Could you please address it before we merge it? /hold
@divya-mohan0209 It's been fixed; it was a relatively small conflict. Probably would need another lgtm.
Np, happy to give it another LGTM based on Tim's comment. I had to issue a hold since PROW does weird things sometimes. /unhold /lgtm
LGTM label has been added.