website
website copied to clipboard
kubernetes
Add blog post for Ensuring Secret Pulled Images
Feature blog post for KEP 2535: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2535-ensure-secret-pulled-images/README.md"
KEP issue: https://github.com/kubernetes/enhancements/issues/2535
Co-authoring with @stlaz
Pull request preview available for checking
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | a23b9f7aaf8a31c06eba47dfb582bfc6a9fabb02 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/681b7208743e0100083ed899 |
| Deploy Preview | https://deploy-preview-49999--kubernetes-io-main-staging.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: benjaminapetersen / name: Ben Petersen (a23b9f7aaf8a31c06eba47dfb582bfc6a9fabb02, 5915eb79bd421ece07b40fe74e4a43a8c59a4852)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
@stlaz: GitHub didn't allow me to request PR reviews from the following users: for, review.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @aramase @liggitt for review
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Many thanks for the reviews! Ben is away for a bit so I fixed the PR for him in the meantime. Though I don't have the perms to mark reviews as resolved, I believe all the comments were addressed and are now included in the post.
There are nits still outstanding but technically from SIG node it LGTM
Updated feedback, have to step away, but will give it my own final review when i return and LGTM per the guide. 👍
Quick cross ref to the related feature post PR: https://github.com/kubernetes/website/pull/50756
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lmktfy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~content/en/blog/OWNERS~~ [lmktfy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Awesome, thanks @lmktfy. Happy to make those last 2 changes as a follow if you like.