website icon indicating copy to clipboard operation
website copied to clipboard

KEP-2862: Graduate to BETA

Open vinayakankugoyal opened this issue 10 months ago • 13 comments

Description

Graduate kep-2862: Fine-grained Kubelet API Authz to BETA.

I looked at the existing docs and they sufficiently cover the details so we don't need to update them. Here is a link to the existing docs just in case. Please feel free to comment on this PR if you think we should update them.

NOTE: the banner showing the feature-gate state now autoupdates based on the config being changed in this PR.

Issue

xref: https://github.com/kubernetes/enhancements/issues/2862

vinayakankugoyal avatar Jan 28 '25 03:01 vinayakankugoyal

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit d2cf48864913064e6a3e6e7f97c68aceff5a279f
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/679a7a451d117e0008fb1ba8

netlify[bot] avatar Jan 28 '25 03:01 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit d2cf48864913064e6a3e6e7f97c68aceff5a279f
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679a7a45a8399d000865d64a
Deploy Preview https://deploy-preview-49578--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 28 '25 03:01 netlify[bot]

Hi @vinayakankugoyal could you please change the feature gate file name to KubeletFineGrainedAuthz.md before making the change as the file name is changed in the main branch. Otherwise, it will create a merge conflict error.

Shubham82 avatar Jan 29 '25 18:01 Shubham82

Hi @vinayakankugoyal could you please change the feature gate file name to KubeletFineGrainedAuthz.md before making the change as the file name is changed in the main branch. Otherwise, it will create a merge conflict error.

were those changes synced to dev-1.33?

vinayakankugoyal avatar Jan 29 '25 18:01 vinayakankugoyal

were those changes synced to dev-1.33?

yes, we sync the dev (dev-1.33) branch with the main branch to keep the dev branch up to date.

Shubham82 avatar Jan 29 '25 19:01 Shubham82

/lgtm

Shubham82 avatar Jan 29 '25 19:01 Shubham82

LGTM label has been added.

Git tree hash: effd503de838789ba7ef747977d306ca6cf12fd3

k8s-ci-robot avatar Jan 29 '25 19:01 k8s-ci-robot

/assing @natalisucks

for approval

vinayakankugoyal avatar Jan 30 '25 22:01 vinayakankugoyal

/assign @natalisucks

vinayakankugoyal avatar Jan 30 '25 22:01 vinayakankugoyal

/assign @natalisucks

vinayakankugoyal avatar Jan 30 '25 22:01 vinayakankugoyal

Hi @dipesh-rawat Could you please approve this PR, so that it will be merged?

Thanks!

Shubham82 avatar Mar 17 '25 06:03 Shubham82

@sftim - could you approve this one? Its been awaiting approval since Jan 30th.

vinayakankugoyal avatar Mar 28 '25 17:03 vinayakankugoyal

@vinayakankugoyal Please provide a link to the upstream k/k change. We are not supposed to merge doc changes before the feature gate change is accepted in the code base. The docs team doesn't have bandwidth to trace all the KEPs and watch all the k/k changes. So, it is your responsibility to show that the change already happened in code (not just in KEP).

tengqm avatar Mar 29 '25 05:03 tengqm

Well this is the first time I'm hearing this ask. The k/k change has been merged already.

vinayakankugoyal avatar Mar 29 '25 10:03 vinayakankugoyal

https://github.com/kubernetes/kubernetes/pull/129656

vinayakankugoyal avatar Mar 29 '25 10:03 vinayakankugoyal

/approve

tengqm avatar Mar 29 '25 10:03 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 29 '25 10:03 k8s-ci-robot