website icon indicating copy to clipboard operation
website copied to clipboard

Document request body contents sent to CRD conversion webhooks, in more detail

Open engedaam opened this issue 1 year ago • 3 comments
trafficstars

This is a Feature Request

What would you like to be added

We recently ran into a scenario where we saw the API Sever send partial/empty object to a conversion webhooks. The issue here is that our team took an invariate that the APIserver will first validate the an object that is created/updated first before it is sent to a CRD conversion webhooks. This turned out to not necessarily be true for server side apply where resource can be pruned and an object that is not valid will be sent to a conversion webhooks.

It would be helpful to document the order of operation the API server will use when converting CRDs between resources, and the requirements need for CRD conversion webhooks to work successful with API Server: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#webhook-conversion

Why is this needed Users implementing conversion webhooks will need to understand the contract and expectation around the action the request object that will need to be sent by the API Server.

Comments

engedaam avatar Sep 23 '24 15:09 engedaam

/language en /priority backlog

/retitle Document request body contents sent to CRD conversion webhooks, in more detail

sftim avatar Sep 23 '24 17:09 sftim

/wg api-expression

sftim avatar Sep 23 '24 17:09 sftim

/sig api-machinery

sftim avatar Sep 24 '24 12:09 sftim

/assign

aryasoni98 avatar Sep 25 '24 19:09 aryasoni98

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 24 '24 20:12 k8s-triage-robot

I think this is worth doing /triage accepted /remove-lifecycle stale

It may be that we can't staff the work, though.

sftim avatar Jan 02 '25 16:01 sftim