website icon indicating copy to clipboard operation
website copied to clipboard

Logo overlaps with other nav bar elements when search bar is present (on Firefox)

Open holistic-developer opened this issue 1 year ago • 13 comments
trafficstars

This is a Bug Report

Problem: On Firefox the kubernetes logo overlaps with other navbar items on .../docs pages when the search bar is present. image

Proposed Solution: Decrease the size of the search bar.

Page to Update: All pages using the layouts/partials/navbar.html which is mostly https://kubernetes.io/docs/

Additional Information I used Firefox version 130 on Mac with a resolution of 1512 x 982

holistic-developer avatar Sep 11 '24 14:09 holistic-developer

This might be related to https://github.com/kubernetes/website/issues/45077

holistic-developer avatar Sep 11 '24 14:09 holistic-developer

/area web-development

dipesh-rawat avatar Sep 11 '24 23:09 dipesh-rawat

/assign

thisisharrsh avatar Sep 12 '24 04:09 thisisharrsh

Facing the same issue at 1512 * 982 resolution. Screenshot from 2024-09-12 10-24-15

thisisharrsh avatar Sep 12 '24 05:09 thisisharrsh

My suggestion: drop the Case Studies section.

sftim avatar Sep 15 '24 09:09 sftim

drop the Case Studies section.

I am planning to adjust the CSS properties for the page at the given size. But I will consider your suggestion also.

thisisharrsh avatar Sep 17 '24 05:09 thisisharrsh

My suggestion: drop the Case Studies section.

I would advise against that.

Here is how it is rendered in chrome at the same resolution: image and again on Firefox image So, the actual issue is the size of the search bar.

holistic-developer avatar Sep 17 '24 07:09 holistic-developer

Thanks @holistic-developer, for the issue rectification.

thisisharrsh avatar Sep 17 '24 08:09 thisisharrsh

@holistic-developer several changes could help:

  • Managing the size of the search bar
  • Dropping the case studies section, which is no longer current
  • Improving how the top nav adapts to the available space (for example, on narrow viewports, we could have an icon rather than a bar for search; clicking the icon could take you to /search)

sftim avatar Sep 17 '24 15:09 sftim

/triage accepted /priority important-soon

katcosgrove avatar Sep 18 '24 10:09 katcosgrove

When I shrink the viewport to a similar width, the search form within the nav bar disappears completely. But maybe this is too dependent on details such as DPI, root element em size, etc.

sftim avatar Sep 18 '24 11:09 sftim

The issue is fixed here.

thisisharrsh avatar Sep 18 '24 12:09 thisisharrsh

  • Managing the size of the search bar

Raised the PR on this approach.

thisisharrsh avatar Sep 18 '24 12:09 thisisharrsh