website icon indicating copy to clipboard operation
website copied to clipboard

Update Documentation for Pod CreationPod creation branch

Open impact-maker opened this issue 1 year ago • 5 comments
trafficstars

Solves https://github.com/kubernetes/kubernetes/issues/126437

Description: This pull request updates the Kubernetes documentation with clear, practical steps for creating Pods. It includes direct links to relevant test files, making it easier for users to follow and implement best practices.

impact-maker avatar Aug 13 '24 10:08 impact-maker

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 13 '24 10:08 k8s-ci-robot

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 42d1e238e9fca94b739611562115fc3e1844fa63
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66bb373ff7bf7900085469b6
Deploy Preview https://deploy-preview-47477--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 13 '24 10:08 netlify[bot]

@impact-maker Thanks you for your contribution. Could you please sign the CLA before the PR can be reviewed. You can follow the steps documented here: https://git.k8s.io/community/CLA.md

dipesh-rawat avatar Aug 13 '24 13:08 dipesh-rawat

This pull request updates the Kubernetes documentation with clear, practical steps for creating Pods. It includes direct links to relevant test files, making it easier for users to follow and implement best practices.

That reads rather like an LLM (such as Claude) wrote it. Could you reword to explain the benefit to Kubernetes that we get from merging it? Think higher level than the existing description.

sftim avatar Sep 17 '24 15:09 sftim

What does this PR bring to users?

tengqm avatar Sep 18 '24 00:09 tengqm

This documentation change doesn't improve the docs as it stands. I will close it; however, you are welcome to open the PR with genuine improvements.

We're always open to contributions and your ambition to transform our docs into something better is appreciated.

/close

sftim avatar Oct 19 '24 21:10 sftim

@sftim: Closed this PR.

In response to this:

This documentation change doesn't improve the docs as it stands. I will close it; however, you are welcome to open the PR with genuine improvements.

We're always open to contributions and your ambition to transform our docs into something better is appreciated.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 19 '24 21:10 k8s-ci-robot