website icon indicating copy to clipboard operation
website copied to clipboard

Change page layout for a tutorial

Open niranjandarshann opened this issue 1 year ago • 13 comments
trafficstars

Updated PageLayout Addressing issue https://github.com/kubernetes/website/issues/44772

297324264-2363c2ff-dd4e-475a-bc2b-a3ce271eca20

Addressing issue https://github.com/kubernetes/website/issues/44772

niranjandarshann avatar Jan 18 '24 06:01 niranjandarshann

Addressing issue #44772

niranjandarshann avatar Jan 18 '24 06:01 niranjandarshann

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 11003da57370c20e92ef504f7a1260820d1162b0
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66d57fd5cc599c00081756f1
Deploy Preview https://deploy-preview-44788--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 18 '24 06:01 netlify[bot]

It will look something like this:

Screenshot from 2024-01-18 12-53-53

niranjandarshann avatar Jan 18 '24 07:01 niranjandarshann

Addressing issue https://github.com/kubernetes/website/issues/44772

Please add this issue number to the PR description (here) and before-and-after screenshots, if possible. This will help reviewers understand the context and assess the changes effectively. Also if possible, specify the screen resolution used for testing.

dipesh-rawat avatar Mar 07 '24 01:03 dipesh-rawat

/area web-development

dipesh-rawat avatar Mar 07 '24 01:03 dipesh-rawat

@dipesh-rawat PTAL! I had made the changes. to attain the goal

niranjandarshann avatar Mar 13 '24 04:03 niranjandarshann

/lgtm

AmarNathChary avatar May 07 '24 06:05 AmarNathChary

Please respond to https://github.com/kubernetes/website/pull/44788/files#r1527482359 @niranjandarshann

Pending that: /lgtm cancel

sftim avatar May 28 '24 17:05 sftim

@niranjandarshann : Please advise whether you're okay making the changes suggested above?

divya-mohan0209 avatar Jun 13 '24 12:06 divya-mohan0209

/retitle Change page layout for a tutorial

sftim avatar Jul 25 '24 08:07 sftim

See https://github.com/kubernetes/website/pull/44788#discussion_r1691033000

sftim avatar Jul 25 '24 08:07 sftim

See #44788 (comment)

Did it

niranjandarshann avatar Jul 25 '24 08:07 niranjandarshann

@niranjandarshann: Thank you for this change! However, as Tim and Dipesh recommend, changing HTML for one page is not feasible.

Please could you advise what changes have been made ever since this comment

divya-mohan0209 avatar Aug 14 '24 06:08 divya-mohan0209

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 02 '24 09:09 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 02 '24 09:09 k8s-ci-robot