website icon indicating copy to clipboard operation
website copied to clipboard

StatefulSets - improvement on RollingUpdates section

Open antaloala opened this issue 3 years ago • 8 comments
trafficstars

I think it would be really useful to comment, at the end of the StatefulSet - Rolling Updates section that if a pod not-yet-upgraded crashes as the rolling update procedure is running, the statefulset controller:

  • pauses the ongoing rolling update procedure (once the being upgraded pod (at the time of that crash) gets the Ready state)
  • re-creates the crashed pod using the "old" PodTemplate (i.e. PodTemplate defined in the StatefulSet object before the patch operation that triggered the ongoing rolling upgrade was committed in API Server)
  • once the re-created pod becomes Ready, resumes the rolling update procedure.

Only exceptions for this behavior:

  • the crashed pod is just the following one in the 'upgrade order list' (in this case it is recreated as part of the ongoing rolling update procedure, using the latest PodTemplate)
  • and/or number of not-yet-updraded crashed pods (from the time the rolling upgrade started) has not reached the .spec.updateStrategy.rollingUpdate.maxUnavailable value yet (only in case Statefulset MaximumUnavailablePods feature is enabled)

antaloala avatar Oct 07 '22 20:10 antaloala

/kind feature /language en

sftim avatar Oct 08 '22 23:10 sftim

/triage accepted

RA489 avatar Oct 28 '22 10:10 RA489

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 26 '23 11:01 k8s-triage-robot

/remove-lifecycle stale

tengqm avatar Jan 26 '23 23:01 tengqm

/retitle StatefulSets - improvement on RollingUpdates section

sftim avatar Dec 28 '23 11:12 sftim

Hey @antaloala are we talking about comments or Notes at the bottom of Rolling Updates!!

justankiit avatar Dec 28 '23 12:12 justankiit

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Dec 27 '24 12:12 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 27 '25 13:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 26 '25 13:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar May 26 '25 14:05 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 26 '25 14:05 k8s-ci-robot