test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

Merging master in feature branch fails because of CLA

Open apelisse opened this issue 7 years ago • 22 comments

Because the bot hasn't signed the CLA, it's not currently possible to merge master back into the feature branch.

apelisse avatar Jul 09 '18 19:07 apelisse

@BenTheElder

apelisse avatar Jul 09 '18 19:07 apelisse

@fejta how did we fix this before with k8s-ci-robot and test-infra? k8s-merge-robot needs the same fix.

BenTheElder avatar Jul 09 '18 20:07 BenTheElder

/kind bug /priority critical-urgent @fejta @BenTheElder was this handled?

stevekuznetsov avatar Aug 31 '18 18:08 stevekuznetsov

this was "handled" by having "feature branch managers" who just force push over the branch IIRC https://github.com/kubernetes/test-infra/blob/1f481a3aff57abfb7346a4faeedcac4bb0744f5c/prow/plugins.yaml#L172-L174

BenTheElder avatar Aug 31 '18 19:08 BenTheElder

We have the similar problem in kubernetes-client/python repo. The release process in client-python requires merging master into release branch. The recently-enabled k8s-ci-bot in that repo blocks the release because it hasn't signed CLA: https://github.com/kubernetes-client/python/pull/650

I suspect other kubernetes-client repos https://github.com/kubernetes/test-infra/pull/9122 that have the bot enabled recently experience the similar issue.

@BenTheElder @fejta Could you advise on how to proceed? :)

roycaihw avatar Oct 15 '18 23:10 roycaihw

https://github.com/kubernetes/test-infra/issues/8241

BenTheElder avatar Oct 16 '18 00:10 BenTheElder

Thanks for the reference @BenTheElder. I thought there were two bots (k8s-ci-robot that does auto-merging and CLAbot that checks CLA) and I was hoping our problem could be solved if the k8s-ci-robot can sign the CLA itself like a general contributor somehow.

I guess we have to force push like how the serverside-apply feature branch does until #8241 is rolled out.

cc @yliaog

roycaihw avatar Oct 16 '18 01:10 roycaihw

I don't know what the correct answer for the k8s-ci-robot is there ... @spiffxp punting this up to steering :^)

BenTheElder avatar Oct 16 '18 21:10 BenTheElder

@BenTheElder - /me channeling Aaron - "as long as you come to steering with a yay or nay proposal" :)

dims avatar Oct 16 '18 21:10 dims

/milestone v1.13

spiffxp avatar Oct 19 '18 00:10 spiffxp

cc @thockin at @spiffxp's suggestion ... should the merge robot have the CLA authorized on its account?

BenTheElder avatar Oct 24 '18 23:10 BenTheElder

@BenTheElder Is this still an issue? I feel like you mentioned one of the bot accounts was now mysteriously passing the CLA check, I can't remember if it was related to this

spiffxp avatar Jan 03 '19 04:01 spiffxp

/remove-milestone

spiffxp avatar Jan 03 '19 04:01 spiffxp

/milestone clear

right, our syntax is inconsistent

spiffxp avatar Jan 03 '19 05:01 spiffxp

IIRC the bot now passes CLA, @fejta can confirm.

BenTheElder avatar Jan 03 '19 19:01 BenTheElder

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot avatar Apr 03 '19 19:04 fejta-bot

/close

per last comment from @BenTheElder

dims avatar Apr 16 '19 13:04 dims

@dims: Closing this issue.

In response to this:

/close

per last comment from @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 16 '19 13:04 k8s-ci-robot

/reopen

The CLA bot no longer (or perhaps never) passes CLA check for PRs where it is the committer (e.g. https://github.com/kubernetes-client/java/pull/3345)

Is there a way to fix this globally with the EasyCLA infrastructure?

brendandburns avatar Apr 24 '24 16:04 brendandburns

@brendandburns: Reopened this issue.

In response to this:

/reopen

The CLA bot no longer (or perhaps never) passes CLA check for PRs where it is the committer (e.g. https://github.com/kubernetes-client/java/pull/3345)

Is there a way to fix this globally with the EasyCLA infrastructure?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 24 '24 16:04 k8s-ci-robot

/sig testing

I read the error message a little more, I think that the email address ([email protected]) needs to be added to the github user for the robot: https://github.com/k8s-ci-robot and then the EasyCLA check will pass (or at least get past the current error)

brendandburns avatar Apr 24 '24 16:04 brendandburns

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 24 '24 17:05 k8s-triage-robot