test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

cluster-api: update pull-cluster-api-e2e-blocking-main resources

Open eddiezane opened this issue 1 year ago • 6 comments

This PR updates the resources for pull-cluster-api-e2e-blocking-main per the contributor summit workshop.

Memory: https://monitoring-eks.prow.k8s.io/d/53g2x7OZz/jobs?orgId=1&refresh=30s&var-org=kubernetes-sigs&var-repo=cluster-api&var-job=pull-cluster-api-e2e-blocking-main&viewPanel=128&from=now-24h&to=now

CPU: https://monitoring-eks.prow.k8s.io/d/53g2x7OZz/jobs?orgId=1&refresh=30s&var-org=kubernetes-sigs&var-repo=cluster-api&var-job=pull-cluster-api-e2e-blocking-main&viewPanel=180&from=now-24h&to=now

Health: https://prow.k8s.io/?job=pull-cluster-api-e2e-blocking-main

eddiezane avatar Mar 19 '24 14:03 eddiezane

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eddiezane Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 19 '24 14:03 k8s-ci-robot

/retest

rjsadow avatar Mar 19 '24 18:03 rjsadow

/hold

We use some templating to generate the prowjob yaml. In this pr we should also change the corresponding template.

chrischdi avatar Mar 20 '24 08:03 chrischdi

cc @xmudrii

eddiezane avatar Mar 20 '24 11:03 eddiezane

/cc

sbueringer avatar Mar 25 '24 06:03 sbueringer

Just back from Kubecon :-) .

The change needs to be done here instead:

https://github.com/eddiezane/test-infra/blob/ez/pull-cluster-api-e2e-blocking-main/config/jobs/kubernetes-sigs/cluster-api/templates/cluster-api-presubmits.yaml.tpl#L206-L210

and to render the new templates:

$ cd /path/to/sigs.k8s.io/cluster-api
$ export TEST_INFRA_DIR=/path/to/k8s.io/test-infra
$ make generate-test-infra-prowjobs

chrischdi avatar Mar 25 '24 11:03 chrischdi

(you can also just make the changes in both places, then it's not necessary to check out CAPI)

sbueringer avatar Mar 25 '24 15:03 sbueringer

/cc @fabriziopandini

sbueringer avatar Apr 03 '24 12:04 sbueringer

Really interesting data in the linked dashboards, thanks for sharing!

lgtm pending comments above

fabriziopandini avatar Apr 03 '24 19:04 fabriziopandini

@eddiezane Thx for getting this started!

We've merged a first PR here https://github.com/kubernetes/test-infra/pull/32376 and will continue to track the work via https://github.com/kubernetes-sigs/cluster-api/issues/10387.

I would close this PR for now. Please let us know if you want to be further involved (but I assume you're pretty busy anyway :)).

/close

sbueringer avatar Apr 05 '24 07:04 sbueringer

@sbueringer: Closed this PR.

In response to this:

@eddiezane Thx for getting this started!

We've merged a first PR here https://github.com/kubernetes/test-infra/pull/32376 and will continue to track the work via https://github.com/kubernetes-sigs/cluster-api/issues/10387.

I would close this PR for now. Please let us know if you want to be further involved (but I sort of assume you're pretty busy anyway :)).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 05 '24 07:04 k8s-ci-robot