test-infra
test-infra copied to clipboard
kubernetes
Deck's build log lens should fail gracefully on large build-log.txt files.
What happened:
A large (e.g. >26MB) build-log.txt cannot be rendered by Spyglass' build log lens due to the file size. The lens shows the spinning loading symbol forever.
What you expected to happen: I don't expect the lens to be able to highlight and render such a large file, but it should fail more gracefully. We should display an error if the file is large enough to have no chance of rendering in time and if a timeout is reached that should be displayed on the front end rather than spinning the loading symbol forever.
How to reproduce it (as minimally and precisely as possible): Create a job with lots of standard output.
/help-wanted
@cjwagner: This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@MaxHorstmann: GitHub didn't allow me to assign the following users: poking, a, little.
Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign poking a little
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
