test-infra
test-infra copied to clipboard
kubernetes
Updated AWS testing variables
Welcome @photra!
It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/test-infra has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @photra. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: photra
To complete the pull request process, please assign randomvariable after the PR has been reviewed.
You can assign the PR to them by writing /assign @randomvariable in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@photra - did i see that we had reverted back to using E2E_FOCUS in CAPA?
@photra - did i see that we had reverted back to using
E2E_FOCUSin CAPA?
Definitely! The revert in CAPA was due to the e2e tests' regex failing. I think it failed because test-infra had not been updated to the new usage, which is included in this PR
Ideally, we need the CAPA change to go in first, so that GINKGO_FOCUS is there. We can then merge this in afterwards.
@sedefsavas - wdyt?
@photra: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@photra - would you be able to rebase this?
@Skarlso @Ankitasw @dlipovetsky - what do you think to getting this merged after a rebase?
Yep, sounds good. I don't like Ginkgo that much, but if we happened to use it I would want all the functionality that it provides. :)
@richardcase I just did. Please let me know if it looks good!
Edit: I accidentally merged earlier. The branch should be rebased now. Sorry about that!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: photra, richardcase
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~config/jobs/kubernetes-sigs/cluster-api-provider-aws/OWNERS~~ [richardcase]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@photra: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:
- key
cluster-api-provider-aws-periodics-clusterclass.yamlusing fileconfig/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-periodics-clusterclass.yaml - key
cluster-api-provider-aws-periodics-release-1.5.yamlusing fileconfig/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-periodics-release-1.5.yaml - key
cluster-api-provider-aws-presubmits.yamlusing fileconfig/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml
In response to this:
Closes #26490
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.