kubernetes
Add unit tests for the obs.go file.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We are missing unit tests for krel obs and this PR attempts to improve coverage
Relevant card from the project board: https://github.com/kubernetes/release/issues/3168
Which issue(s) this PR fixes:
It improves unit test coverage for the krel obs
Special notes for your reviewer:
The pattern for tests has been borrowed from anago_test.go file as code looks very similar. While structure is the same, test cases have been tailored for the obs package.
Does this PR introduce a user-facing change?
NONE
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: TatianaSelezneva (558c55de32932f5d26ab9135ce84818eabe3c18d)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @TatianaSelezneva!
It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/release has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @TatianaSelezneva. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@xmudrii , I'm wondering if you could please have a look? It adds unit tests for obs.go file, a first step towards completing https://github.com/kubernetes/release/issues/3168.
To complete the card more unit tests are required, but I would prefer to avoid big PRs if I can, plus it would be good to get a feedback to understand if I'm moving in the right direction.
Thank you!
@TatianaSelezneva I didn't forget about this, it's in my inbox, but I'm a bit busy at the moment. I'll do my best to review this latest tomorrow.
@xmudrii Thank you for the reviewing! I have fixed the year. Regarding the delay it is fine as I have been busy myself and it worked out well actually :) Thank you for fixing labels, hopefully I'll do a better job next time.
I did commit amend this time, and realised now it is not obvious that fixing the year as requested was the only change. Probably I should have added separate commit, apologies. Please let me know if this is the case and I'll do it correctly next time.
I did commit amend this time, and realised now it is not obvious that fixing the year as requested was the only change. Probably I should have added separate commit, apologies. Please let me know if this is the case and I'll do it correctly next time.
No worries, it's all okay this way as well, I do it often too. :)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: TatianaSelezneva, xmudrii
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/OWNERS~~ [xmudrii]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment