release icon indicating copy to clipboard operation
release copied to clipboard

add darwin/arm64 to kube-cross

Open pacoxu opened this issue 1 year ago • 11 comments

Should we build the M1 Macbook kube-cross?

None

pacoxu avatar Nov 22 '24 05:11 pacoxu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu Once this PR has been reviewed and has the lgtm label, please assign puerco for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 22 '24 05:11 k8s-ci-robot

/assign @dims @saschagrunert

pacoxu avatar Nov 22 '24 05:11 pacoxu

@pacoxu is this mainly for local development?

saschagrunert avatar Nov 22 '24 08:11 saschagrunert

if we already build for mac amd64 i think we should do the same for arm, if that does not add any issues

cpanato avatar Nov 22 '24 08:11 cpanato

@pacoxu is this mainly for local development?

@saschagrunert yes, only for local build.

pacoxu avatar Dec 24 '24 06:12 pacoxu

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 24 '25 07:03 k8s-triage-robot

https://github.com/kubernetes/release/issues/2706 (I think from previous sig release thread?)

I'm pretty sure we can drop this, but forgot to circle back to it ...

BenTheElder avatar Mar 24 '25 23:03 BenTheElder

We use it to attempt to precompile the stdlib, but that's fragile (it assumes the same build options) and probably unnecessary.

BenTheElder avatar Mar 24 '25 23:03 BenTheElder

/test pull-release-cluster-up [Ignore, just checking if this job even works, I think we need to drop a stale flag from it, it normally runs on PRs that touch push-build.sh, I will clear the status after it runs]

BenTheElder avatar Mar 24 '25 23:03 BenTheElder

@pacoxu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-release-cluster-up c82c5bb26a4a7cad09d2c0fc24b2ff82c790012a link true /test pull-release-cluster-up

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Mar 24 '25 23:03 k8s-ci-robot

/skip

BenTheElder avatar Mar 24 '25 23:03 BenTheElder

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 24 '25 00:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar May 24 '25 00:05 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 24 '25 00:05 k8s-ci-robot