release icon indicating copy to clipboard operation
release copied to clipboard

Dependency update - Golang 1.23

Open cpanato opened this issue 1 year ago • 15 comments

Tracking info

Link to any previous tracking issue: https://github.com/kubernetes/release/issues/3280

Golang mailing list announcement: https://groups.google.com/g/golang-announce/c/8ciOP5ve_CM/m/fg9_BQpdFgAJ

SIG Release Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1719215856518939

Work items for go1.23.0

  • [x] kube-cross, go-runner, releng-ci image updates: https://github.com/kubernetes/release/pull/3732

    • [x] kube-cross image promotion: https://github.com/kubernetes/k8s.io/pull/7238
    • [x] go-runner image promotion: https://github.com/kubernetes/k8s.io/pull/7239
    • [x] releng-ci image promotion: https://github.com/kubernetes/k8s.io/pull/7240

After go-runner image promotion

  • [x] distroless-iptables image update: https://github.com/kubernetes/release/pull/3736

    • [x] image promotion: https://github.com/kubernetes/k8s.io/pull/7249

Work items for go1.23rc1

  • [x] kube-cross, go-runner, releng-ci image updates: https://github.com/kubernetes/release/pull/3669

    • [x] kube-cross image promotion: https://github.com/kubernetes/k8s.io/pull/6953
    • [x] go-runner image promotion: https://github.com/kubernetes/k8s.io/pull/6954
    • [x] releng-ci image promotion: not promoting this image

After go-runner image promotion

  • [x] distroless-iptables image update: https://github.com/kubernetes/release/pull/3672

    • [x] image promotion: https://github.com/kubernetes/k8s.io/pull/6959

Work items for go1.23rc2

  • [x] kube-cross, go-runner, releng-ci image updates: https://github.com/kubernetes/release/pull/3680

    • [x] kube-cross image promotion: https://github.com/kubernetes/k8s.io/pull/7023
    • [x] go-runner image promotion: https://github.com/kubernetes/k8s.io/pull/7021
    • [x] releng-ci image promotion: not promoting this image

After go-runner image promotion

  • [x] distroless-iptables image update: https://github.com/kubernetes/release/pull/3685

    • [x] image promotion: https://github.com/kubernetes/k8s.io/pull/7029

After kube-cross and distroless-iptables image promotions

  • [x] kubernetes/kubernetes update (master): https://github.com/kubernetes/kubernetes/pull/126047

    Ensure the following have been updated within the PR:

    • [x] .go-version file
    • [x] kube-cross image
    • [x] go-runner image
    • [x] distroless-iptables image
    • [x] publishing bot rules
    • [x] test image

Note This update may require an update to go.sum files, for example: https://github.com/kubernetes/kubernetes/pull/118507 This will require an API Review approval.

After kubernetes/kubernetes (master) has been updated

  • [x] k8s-cloud-builder and k8s-ci-builder image updates: https://github.com/kubernetes/release/pull/3690
  • [x] kubekins/krte image variants update: https://github.com/kubernetes/test-infra/pull/33093

Follow-up items

  • [ ] Ensure the Golang issue template is updated with any new requirements
  • [ ] <Any other follow up items>

/assign cc: @kubernetes/release-engineering

cpanato avatar Jun 24 '24 07:06 cpanato

cc @MadhavJivrajani @liggitt

cpanato avatar Jun 24 '24 07:06 cpanato

Tracking PRs related to go1.23 that we would need to pick to release branches as part of an eventual update to go1.23:

  • https://github.com/kubernetes/kubernetes/pull/125926 and https://github.com/kubernetes/kubernetes/pull/126709

    • 1.31: https://github.com/kubernetes/kubernetes/pull/126710
    • 1.30: https://github.com/kubernetes/kubernetes/pull/126712
    • 1.29: https://github.com/kubernetes/kubernetes/pull/126713
    • 1.28: https://github.com/kubernetes/kubernetes/pull/126714
  • https://github.com/kubernetes/kubernetes/pull/127271 (TODO: pick the godebug default=go1.x commit from PR to release branches)

    • 1.31:
    • 1.30:
    • 1.29:

Tracking verification of conditions for bumping go1.21 on release branches:

  • [ ] TBD: 3 months after go 1.22 release (TBD)
  • [ ] TBD: 1 month after Kubernetes 1.30/Kubernetes 1.31 release on go1.23 (TBD)
  • [ ] no regressions relative to go 1.23 known to impact Kubernetes
    • [ ]
  • [ ] pass unit and integration tests with both go 1.23 and the original go version for the release branch
    • [ ] 1.27:
    • [ ] 1.28:
    • [ ] 1.29:
  • [ ] any behavior changes in go 1.23 are mitigated to preserve existing behavior without requiring action by Kubernetes end-users
    • [ ] 1.28:
    • [ ] 1.29:
    • [ ] 1.30:

Tracking the PR that actually bumps to go1.22:

  • [ ]
    • [ ] 1.28:
    • [ ] 1.29:
    • [ ] 1.30

MadhavJivrajani avatar Jul 05 '24 20:07 MadhavJivrajani

RC2 released: https://groups.google.com/g/golang-announce/c/jW315Nz132s/m/WqkCDaiVBQAJ

cpanato avatar Jul 16 '24 15:07 cpanato

https://github.com/kubernetes/release/pull/3685 post run of this PR failed:

  • https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-distroless-iptables/1813995910510678016

pacoxu avatar Jul 29 '24 07:07 pacoxu

go 1.23.0 is out now, can rebump master to 1.23 now 🎉

liggitt avatar Aug 20 '24 15:08 liggitt

all done

/close

cpanato avatar Sep 03 '24 21:09 cpanato

@cpanato: Closing this issue.

In response to this:

all done

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 03 '24 21:09 k8s-ci-robot

should we keep this open for tracking changes required for go 1.23 (like https://github.com/kubernetes/release/issues/3280#issuecomment-1726964825), and backport of 1.23 to release branches?

liggitt avatar Sep 04 '24 15:09 liggitt

/reopen

cpanato avatar Sep 04 '24 15:09 cpanato

@cpanato: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 04 '24 15:09 k8s-ci-robot

Can we add an item to https://github.com/kubernetes/release/issues/3650#issuecomment-2211373351 to pick the godebug default=go1.x commit from https://github.com/kubernetes/kubernetes/pull/127271 to release branch go.mod files?

xref https://tip.golang.org/doc/godebug#default

liggitt avatar Sep 10 '24 16:09 liggitt

can update https://github.com/kubernetes/release/issues/3650#issuecomment-2211373351 with https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr+KUBE_HACK_TOOLS_GOTOOLCHAIN+is%3Aclosed+is%3Amerged merges and picks, which picked up the https://github.com/kubernetes/kubernetes/pull/125926 and https://github.com/kubernetes/kubernetes/pull/126709 backports to 1.29

liggitt avatar Feb 15 '25 02:02 liggitt

Timeline and go1.23 quality-wise, I think we're ready to proceed bumping 1.29-1.31 to go 1.23

liggitt avatar Feb 15 '25 02:02 liggitt

PRs open to bump release branches to go 1.29 - https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr++-base%3Amaster+author%3Aliggitt+1.23.6+

still needs go-runner / builder / kube-cross images built

liggitt avatar Feb 15 '25 18:02 liggitt

Timeline and go1.23 quality-wise, I think we're ready to proceed bumping 1.29-1.31 to go 1.23

I can do the bumps, please let me know

cpanato avatar Feb 17 '25 15:02 cpanato

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 21 '25 08:05 k8s-triage-robot

Could it be that this is done?

sbueringer avatar May 21 '25 08:05 sbueringer

yep

/close

cpanato avatar May 21 '25 12:05 cpanato

@cpanato: Closing this issue.

In response to this:

yep

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 21 '25 12:05 k8s-ci-robot