release icon indicating copy to clipboard operation
release copied to clipboard
verified publisher icon kubernetes

Add presubmit job to run rpmlint on package specs

Open xmudrii opened this issue 2 years ago • 10 comments

What would you like to be added:

Add a presubmit job to run rpmlint on package specs. This is needed because OBS has strict rpmlint settings which can fail the build process. To avoid this happening, we should run rpmlint on our own as well.

xmudrii avatar Jul 24 '23 14:07 xmudrii

I think we can also integrate it into pull-release-verify if the dependency chain is not too big.

saschagrunert avatar Jul 24 '23 14:07 saschagrunert

We now have rpmlint in gcr.io/k8s-staging-releng/releng-ci:latest-go1.20-bookworm. I think we have to generate the specs for a possible verification step using krel obs --spec-only … and then run rpmlint against the results.

saschagrunert avatar Jul 24 '23 15:07 saschagrunert

Yes, that would be the plan. I can take care of that when working on tests for the OBS implementation which should be soon.

xmudrii avatar Jul 24 '23 15:07 xmudrii

@xmudrii this is a good opportunity to include other @kubernetes/release-managers and mentor them into the code. Let's check if anyone is interested in contributing here.

saschagrunert avatar Jul 24 '23 15:07 saschagrunert

@saschagrunert Sounds good to me!

xmudrii avatar Jul 24 '23 15:07 xmudrii

discussed with marko and i will take this /assign

cpanato avatar Jul 25 '23 15:07 cpanato

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 25 '24 05:01 k8s-triage-robot

/remove-lifecycle stale

xmudrii avatar Jan 25 '24 09:01 xmudrii

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 24 '24 09:04 k8s-triage-robot

/remove-lifecycle stale

xmudrii avatar Apr 24 '24 10:04 xmudrii