org
org copied to clipboard
REQUEST: Migrate elmiko/karpenter-provider-cluster-api
New repo, staging repo, or migrate existing
migrate existing elmiko/karpenter-provider-cluster-api
Is it a staging repo?
no
Requested name for new repository
karpenter-provider-cluster-api
Which Organization should it reside
kubernetes-sigs
Who should have admin access?
elmiko, fabriziopandini, sbueringer, vincepri
Who should have write access?
elmiko, mtulio, vrabbi, mtougeron, chrischdi, enxebre, fabriziopandini, killianmuldoon, sbueringer, vincepri
Who should be listed as approvers in OWNERS?
elmiko, mtulio, vrabbi, mtougeron, chrischdi, enxebre, fabriziopandini, killianmuldoon, sbueringer, vincepri
Who should be listed in SECURITY_CONTACTS?
elmiko, fabriziopandini, vincepri
What should the repo description be?
Cluster API Karpenter provider. Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.
What SIG and subproject does this fall under?
sig cluster-lifecycle, sub-project cluster-api
Please provide references to appropriate approval for this new repo
The naming and migration of the repo has been discussed with the SIG Autoscaling community on 2024-01-15, and the Karpenter community on 2024-01-18, and most recently in the Cluster API community on 2024-08-07.
Additional context for request
This topic will also be discussed after a consensus period on 20 August at the next SIG Cluster Lifecycle meeting.
/sig cluster-lifecycle
happy for comments on this PR, but we don't want to merge this until after the SIG cluster lifecycle meeting on 20 August 2024.
/hold until 2024-08-20
+1
+1
+1
github team, we discussed that we need consensus from the sig leads before the migration. waiting on @fabriziopandini and @justinsb
Nit: new name could/should be in line with other providers like cluster-api-provider-karpenter
@vincepri since this is a provider for karpenter i was continuing the naming scheme that aws and azure had established: https://github.com/aws/karpenter-provider-aws, https://github.com/azure/karpenter-provider-azure
just to be clear, the repo in question here does not create cluster-api controllers, it makes a karpenter binary.
I'm +1 to host the project in this incubation phase. Considering the topic, It would be great to have some +1 also from SIG autoscaling and karpenter working group folks Similarly, it would be well accepted to see other folks who participated to the initial design phase to step up as a maintainer (possibily from a mix of companies too)
Considering the topic, It would be great to have some +1 also from SIG autoscaling and karpenter working group folks Similarly, it would be well accepted to see other folks who participated to the initial design phase to step up as a maintainer (possibily from a mix of companies too)
agreed, i think that would be great.
cc @jonathan-innis @ellistarn @gjtempleton @MaciekPytel to cover karpenter and sig autoscaling people
for the other maintainers, perhaps we should have a discussion at a cluster-api office hours? (i can think of a few people who would be good candidates)
just a quick update, i am planning to attend upcoming sig autoscaling and karpenter wg meetings, and also reach out to a few people directly about maintainership. happy to also have a conversation at an upcoming cluster api meeting.
+1 @gjtempleton Unless you have some objections from sig-autoscaling side?
Also - I agree with comments above, we should have someone from karpenter side +1 as well.
i've added Marco Braga (@mtulio) as another owner, he is a colleague at Red Hat who has been following and participating in the initial design work around karpenter capi, and he also has some experience operating karpenter for aws.
i've added Scott Rosenberg (@vrabbi) as another owner, he is a peer from TeraSky who has participated in many of the design and implementation discussions, and has been experimenting with the provider.
i've added Mike Tougeron (@mtougeron) as another owner, he is a peer from Adobe who has participated in the early design and implementation discussions, he also has good experience with cluster-api and has been a regular participant in that community.
Thank you @elmiko, exciting progress.
+1, cool stuff
@neolit123 @elmiko @fabriziopandini It seems we have reached consensus all around, are we okay to proceed with the migration of the repository?
i was waiting for @elmiko to give a ping about that.
hey all, thank you, and yes @vincepri i think we have met all the requests here.
@cblecker @Priyankasaggu11929 could you please assist us with this request? sorry for the long conversation on the ticket.
+1, karpenter-provider-cluster-api sounds good to me. Excited to see more providers in the community!
+1 Great work @elmiko
/assign
@elmiko – following the kubernetes-repositories.md#rules-for-donated-repositories, there are a few items that needs addressing before we initiate the migration process:
-
code-of-conduct.md file needs to be added to the https://github.com/elmiko/karpenter-provider-cluster-api repo.
-
following listed folks for admin/write privileges to the repo, are currently not part of the
kubernetes-sigsGitHub org:- @mtulio – will need to apply for org membership before they can be given access to the migrated repo: https://github.com/kubernetes/community/blob/master/community-membership.md#requirements
- @vrabbi – since you're already part of the kubernetes org, I can PR you in to the kubernetes-sigs org directly. No separate request needed.
-
[Blocking] We need to ensure that all existing committers to the code of
karpenter-provider-cluster-apirepo have signed the CNCF CLA- @daimaxiaxie – could you please confirm if you have already signed the CNCF CLA? If not, please do so before we can proceed with the migration. If you have concerns with signing the CLA and you do not wish to, we'll need to add a NOTICE file to the repo to document your contributions (example).
@elmiko – I will send you an invite to an intermediary org to transfer the repo to Kubernetes project, once above item are addressed. Thank you!
thanks @Priyankasaggu11929 !
i've added the code-of-conduct.md file.
i am working with @mtulio to join the kubernetes-sigs.
i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+
Late to the party on this, but +1 from me as well, great to see.
i've added the code-of-conduct.md file.
i am working with @mtulio to join the kubernetes-sigs.
i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+
Thanks for the confirmation @elmiko. I've invited you to the intermediary org for repo transfer.
thanks @Priyankasaggu11929 !
i've added the code-of-conduct.md file.
i am working with @mtulio to join the kubernetes-sigs.
i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+
Yes, I signed the CLA. thanks!
i've added the code-of-conduct.md file.
i am working with @mtulio to join the kubernetes-sigs.
The membership request has been opened on https://github.com/kubernetes/org/issues/5149! Thanks, @elmiko !
i've added the code-of-conduct.md file. i am working with @mtulio to join the kubernetes-sigs. i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+
Thanks for the confirmation @elmiko. I've invited you to the intermediary org for repo transfer.
@elmiko – friendly ping – this request is currently awaiting the transfer of repo to the intermediate organisation. Thanks!