org icon indicating copy to clipboard operation
org copied to clipboard

REQUEST: Migrate elmiko/karpenter-provider-cluster-api

Open elmiko opened this issue 1 year ago • 34 comments

New repo, staging repo, or migrate existing

migrate existing elmiko/karpenter-provider-cluster-api

Is it a staging repo?

no

Requested name for new repository

karpenter-provider-cluster-api

Which Organization should it reside

kubernetes-sigs

Who should have admin access?

elmiko, fabriziopandini, sbueringer, vincepri

Who should have write access?

elmiko, mtulio, vrabbi, mtougeron, chrischdi, enxebre, fabriziopandini, killianmuldoon, sbueringer, vincepri

Who should be listed as approvers in OWNERS?

elmiko, mtulio, vrabbi, mtougeron, chrischdi, enxebre, fabriziopandini, killianmuldoon, sbueringer, vincepri

Who should be listed in SECURITY_CONTACTS?

elmiko, fabriziopandini, vincepri

What should the repo description be?

Cluster API Karpenter provider. Karpenter is a Kubernetes Node Autoscaler built for flexibility, performance, and simplicity.

What SIG and subproject does this fall under?

sig cluster-lifecycle, sub-project cluster-api

Please provide references to appropriate approval for this new repo

The naming and migration of the repo has been discussed with the SIG Autoscaling community on 2024-01-15, and the Karpenter community on 2024-01-18, and most recently in the Cluster API community on 2024-08-07.

Additional context for request

This topic will also be discussed after a consensus period on 20 August at the next SIG Cluster Lifecycle meeting.

elmiko avatar Aug 08 '24 20:08 elmiko

/sig cluster-lifecycle

elmiko avatar Aug 08 '24 20:08 elmiko

happy for comments on this PR, but we don't want to merge this until after the SIG cluster lifecycle meeting on 20 August 2024.

/hold until 2024-08-20

elmiko avatar Aug 08 '24 20:08 elmiko

+1

vincepri avatar Aug 08 '24 21:08 vincepri

+1

chrischdi avatar Aug 09 '24 06:08 chrischdi

+1

neolit123 avatar Aug 09 '24 15:08 neolit123

github team, we discussed that we need consensus from the sig leads before the migration. waiting on @fabriziopandini and @justinsb

neolit123 avatar Aug 09 '24 15:08 neolit123

Nit: new name could/should be in line with other providers like cluster-api-provider-karpenter

vincepri avatar Aug 12 '24 03:08 vincepri

@vincepri since this is a provider for karpenter i was continuing the naming scheme that aws and azure had established: https://github.com/aws/karpenter-provider-aws, https://github.com/azure/karpenter-provider-azure

just to be clear, the repo in question here does not create cluster-api controllers, it makes a karpenter binary.

elmiko avatar Aug 12 '24 13:08 elmiko

I'm +1 to host the project in this incubation phase. Considering the topic, It would be great to have some +1 also from SIG autoscaling and karpenter working group folks Similarly, it would be well accepted to see other folks who participated to the initial design phase to step up as a maintainer (possibily from a mix of companies too)

fabriziopandini avatar Aug 27 '24 08:08 fabriziopandini

Considering the topic, It would be great to have some +1 also from SIG autoscaling and karpenter working group folks Similarly, it would be well accepted to see other folks who participated to the initial design phase to step up as a maintainer (possibily from a mix of companies too)

agreed, i think that would be great.

cc @jonathan-innis @ellistarn @gjtempleton @MaciekPytel to cover karpenter and sig autoscaling people

for the other maintainers, perhaps we should have a discussion at a cluster-api office hours? (i can think of a few people who would be good candidates)

elmiko avatar Aug 28 '24 20:08 elmiko

just a quick update, i am planning to attend upcoming sig autoscaling and karpenter wg meetings, and also reach out to a few people directly about maintainership. happy to also have a conversation at an upcoming cluster api meeting.

elmiko avatar Sep 03 '24 14:09 elmiko

+1 @gjtempleton Unless you have some objections from sig-autoscaling side?

Also - I agree with comments above, we should have someone from karpenter side +1 as well.

MaciekPytel avatar Sep 09 '24 13:09 MaciekPytel

i've added Marco Braga (@mtulio) as another owner, he is a colleague at Red Hat who has been following and participating in the initial design work around karpenter capi, and he also has some experience operating karpenter for aws.

elmiko avatar Sep 10 '24 13:09 elmiko

i've added Scott Rosenberg (@vrabbi) as another owner, he is a peer from TeraSky who has participated in many of the design and implementation discussions, and has been experimenting with the provider.

elmiko avatar Sep 10 '24 16:09 elmiko

i've added Mike Tougeron (@mtougeron) as another owner, he is a peer from Adobe who has participated in the early design and implementation discussions, he also has good experience with cluster-api and has been a regular participant in that community.

elmiko avatar Sep 10 '24 17:09 elmiko

Thank you @elmiko, exciting progress.

vincepri avatar Sep 11 '24 00:09 vincepri

+1, cool stuff

ellistarn avatar Sep 11 '24 16:09 ellistarn

@neolit123 @elmiko @fabriziopandini It seems we have reached consensus all around, are we okay to proceed with the migration of the repository?

vincepri avatar Sep 11 '24 16:09 vincepri

i was waiting for @elmiko to give a ping about that.

neolit123 avatar Sep 11 '24 16:09 neolit123

hey all, thank you, and yes @vincepri i think we have met all the requests here.

elmiko avatar Sep 11 '24 17:09 elmiko

@cblecker @Priyankasaggu11929 could you please assist us with this request? sorry for the long conversation on the ticket.

neolit123 avatar Sep 11 '24 17:09 neolit123

+1, karpenter-provider-cluster-api sounds good to me. Excited to see more providers in the community!

jonathan-innis avatar Sep 11 '24 18:09 jonathan-innis

+1 Great work @elmiko

fabriziopandini avatar Sep 11 '24 20:09 fabriziopandini

/assign

@elmiko – following the kubernetes-repositories.md#rules-for-donated-repositories, there are a few items that needs addressing before we initiate the migration process:

  • code-of-conduct.md file needs to be added to the https://github.com/elmiko/karpenter-provider-cluster-api repo.

  • following listed folks for admin/write privileges to the repo, are currently not part of the kubernetes-sigs GitHub org:

    • @mtulio – will need to apply for org membership before they can be given access to the migrated repo: https://github.com/kubernetes/community/blob/master/community-membership.md#requirements
    • @vrabbi – since you're already part of the kubernetes org, I can PR you in to the kubernetes-sigs org directly. No separate request needed.
  • [Blocking] We need to ensure that all existing committers to the code of karpenter-provider-cluster-api repo have signed the CNCF CLA

    • @daimaxiaxie – could you please confirm if you have already signed the CNCF CLA? If not, please do so before we can proceed with the migration. If you have concerns with signing the CLA and you do not wish to, we'll need to add a NOTICE file to the repo to document your contributions (example).

@elmiko – I will send you an invite to an intermediary org to transfer the repo to Kubernetes project, once above item are addressed. Thank you!

Priyankasaggu11929 avatar Sep 12 '24 06:09 Priyankasaggu11929

thanks @Priyankasaggu11929 !

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

elmiko avatar Sep 12 '24 12:09 elmiko

Late to the party on this, but +1 from me as well, great to see.

gjtempleton avatar Sep 12 '24 12:09 gjtempleton

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

Thanks for the confirmation @elmiko. I've invited you to the intermediary org for repo transfer.

Priyankasaggu11929 avatar Sep 12 '24 13:09 Priyankasaggu11929

thanks @Priyankasaggu11929 !

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

Yes, I signed the CLA. thanks!

daimaxiaxie avatar Sep 13 '24 03:09 daimaxiaxie

i've added the code-of-conduct.md file.

i am working with @mtulio to join the kubernetes-sigs.

The membership request has been opened on https://github.com/kubernetes/org/issues/5149! Thanks, @elmiko !

mtulio avatar Sep 13 '24 20:09 mtulio

i've added the code-of-conduct.md file. i am working with @mtulio to join the kubernetes-sigs. i believe @daimaxiaxie has signed the CLA since they have merged PRs to the autoscaler, see https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+is%3Aclosed+author%3Adaimaxiaxie+

Thanks for the confirmation @elmiko. I've invited you to the intermediary org for repo transfer.

@elmiko – friendly ping – this request is currently awaiting the transfer of repo to the intermediate organisation. Thanks!

Priyankasaggu11929 avatar Sep 23 '24 06:09 Priyankasaggu11929