org icon indicating copy to clipboard operation
org copied to clipboard

Add uriel-guzman as maintainer to pdcsi and filestorecsi github repos

Open uriel-guzman opened this issue 1 year ago • 7 comments

This add write permissions for uriel-guzman to gcp-compute-persistent-disk-csi-driver and gcp-filestore-csi-driver repositories.

uriel-guzman avatar May 30 '24 16:05 uriel-guzman

Welcome @uriel-guzman!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar May 30 '24 16:05 k8s-ci-robot

Hi @uriel-guzman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 30 '24 16:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: uriel-guzman Once this PR has been reviewed and has the lgtm label, please assign nikhita for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 30 '24 16:05 k8s-ci-robot

/cc @mattcary

uriel-guzman avatar May 30 '24 16:05 uriel-guzman

/hold

I believe Uriel still needs to get kubernetes-sig membership before we can do this. We'll look into it.

mattcary avatar May 30 '24 17:05 mattcary

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 15 '24 21:06 k8s-ci-robot

Ping @uriel-guzman, is this PR still needed or ok to close now? Thanks!

Priyankasaggu11929 avatar Aug 07 '24 05:08 Priyankasaggu11929

/lifecycle stale

cblecker avatar Sep 25 '24 00:09 cblecker

Hi there! We're still working on getting myself K8S Sig Membership. I will close this PR and open a new one once that dependency is resolved to avoid folks expecting an update here! Thanks for keeping track of the latest status.

uriel-guzman avatar Sep 25 '24 17:09 uriel-guzman