minikube icon indicating copy to clipboard operation
minikube copied to clipboard

spelling: Fix spelling errors with codespell

Open Varsius opened this issue 1 week ago • 5 comments

This PR introduces another round of spellchecking, similar to #21273.

While #21273 proposes adding a codespell step to CI, I would currently advise against doing so. The number of false positives is still too high, and there is no clean way to generically exclude them. Additionally, the majority of the identified issues require manual decisions between multiple valid alternatives.

For reference, this is the command I used to identify most of the changes in this PR:

codespell --skip '*.yaml,*.tmpl,*.json,*.html,*.patch,go.sum,./third_party' -i 3 -w

Varsius avatar Dec 09 '25 18:12 Varsius

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Varsius / name: Valentin Küchler (084c1f2d9c6bb1e4990dbddf6e40db920f68f72c)

Welcome @Varsius!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Dec 09 '25 18:12 k8s-ci-robot

Hi @Varsius. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Dec 09 '25 18:12 k8s-ci-robot

Can one of the admins verify this patch?

minikube-bot avatar Dec 09 '25 18:12 minikube-bot

/lgtm

medyagh avatar Dec 17 '25 07:12 medyagh

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, Varsius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 17 '25 07:12 k8s-ci-robot

@Varsius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-vfkit-docker-macos-arm64 084c1f2d9c6bb1e4990dbddf6e40db920f68f72c link false /test integration-vfkit-docker-macos-arm64
integration-docker-crio-linux-x86-64 084c1f2d9c6bb1e4990dbddf6e40db920f68f72c link true /test integration-docker-crio-linux-x86-64
integration-docker-containerd-linux-x86-64 084c1f2d9c6bb1e4990dbddf6e40db920f68f72c link true /test integration-docker-containerd-linux-x86-64
integration-kvm-containerd-linux-x86-64 084c1f2d9c6bb1e4990dbddf6e40db920f68f72c link true /test integration-kvm-containerd-linux-x86-64
integration-kvm-docker-linux-x86-64 084c1f2d9c6bb1e4990dbddf6e40db920f68f72c link true /test integration-kvm-docker-linux-x86-64
integration-kvm-crio-linux-x86-64 084c1f2d9c6bb1e4990dbddf6e40db920f68f72c link true /test integration-kvm-crio-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Dec 17 '25 08:12 k8s-ci-robot