kubernetes
Add a default cluster dns name config
Add a default cluster DNS name config
It is very handy to be able to store the default cluster DNS name so
that I can fire up and teardown clusters easily without losing that
setting. You can think of this as a default value for the
start --dns-domain <val> flag, but only when starting a new cluster.
In my particular case, I would like to set my default cluster dna domain
to a subdomain under a domain that I control. E.g.
cluster.wt.user.dev.example.com. I want to do this to make it easier
to manage TLS certs for my dev cluster.
For context, the start --dns-domain <val> flag works like this:
If you fire up a new cluster with that flag, you will get a new cluster
with the domain name base. If you start an existing cluster, the
config will be updated to the new domain name base and then started.
This config will work a little differently. The change implements a config that will only affect newly started cluster. Here are some examples to show that difference:
Newly started cluster example:
$ minikube config set DefaultDNSDomain cluster2.local
$ minikube start
...
Stop and starting the cluster with --dns-domain flag:
$ minikube stop
...
$ minikub start --dns-domain cluster3.local
...
Stopping and starting a new cluster with a non-default domain name and
without the --dns-domain flag:
$ minikube stop
...
$ minikub start
...
The reason for this behavior is that I am not configuring the name of a cluster. That is a cluster configuration option. I am setting the default for that.
If I manually overrode the name of a cluster when started previously, I don't want a default option to override my cluster configuration.
Before: User cannot cannot change the default DNS domain name for a cluster to something other than cluster.local.
On cluster creation/start:
If a user runs minikube start without a --dnsDomain flag, the
cluster will have the dns domain "cluster.local". A cluster setting
is persisted.
If a user runs 'minikube start --dnsDomain cluster.example.com`, the
cluster will hae the dns domain "cluster.example.com". A cluster
setting is persisted.
On cluster restart:
If a user run minikube start, the cluster's existing dns domain
(pulled from the persisted cluster config) dns domain will be used.
If a user runs `minikube start --dnsDomain cluster.example.com`, the
cluster's persisted dns name will be updated to the new name and the
cluster will be started with the new domain ("cluster.example.com").
Example command sequence:
$ minikube start --dnsDomain=cluster.example.com
# cluster now has dns domain "cluster.example.com"
$ minikube delete
$ minikube start
# cluster now has dns domain "cluster.local"
After:
The behavior of the minikube start flag --dns-domain does not
change at all. When the new configuration value is not set, all of the
behaviors from the "Before" section above will not change.
User can set the default cluster domain name to whatever they want
via the config option DefaultDNSDomain. E.g.:
minikube config set DefaultDNSDomain cluster.wt.users.dev.example.com
Since the case with no configuration is the same as before, here is a description of what happens only with the new configuration set like above.
On cluster creation/start:
If a user runs minikube start without a --dnsDomain flag, the
cluster will have the dns domain "cluster.wt.users.dev.example.com".
A cluster setting is persisted. This is the only thing that changes
with the configuration option set.
If a user runs 'minikube start --dnsDomain cluster.example.com`, the
cluster will hae the dns domain "cluster.example.com". A cluster
setting is persisted.
On cluster restart:
If a user run minikube start, the cluster's existing dns domain
(pulled from the persisted cluster config not from the new config)
dns domain will be used.
If a user runs `minikube start --dnsDomain cluster.example.com`, the
cluster's persisted dns name will be updated to the new name and the
cluster will be started with the new domain ("cluster.example.com").
Notice that the only case that changes with the new setting defined is the case of starting a new cluster. Setting the config will change the behavior of the "Before -> Example command sequence" section as described:
Example command sequence:
$ minikube config set DefaultDNSDomain cluster.wt.users.dev.example.com
$ minikube start --dnsDomain=cluster.example.com
# cluster now has dns domain "cluster.example.com"
$ minikube delete
$ minikube start
# cluster now has dns domain "cluster.wt.users.dev.example.com"
The important piece here is that I can now change the default dnsDomain so that I don't have to specify it explicitly. This is useful when I am starting and deleting a single cluster where I want the top-level domain default to be a subdomain of a domain I control.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: wt / name: Wren Turkal (5777fc0d273bf60f9e779448f39669b5ab661f85)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @wt!
It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/minikube has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @wt. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: wt Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I asked about this feature here: https://kubernetes.slack.com/archives/C1F5CT6Q1/p1752280310063959
I have updated the commit message with details about the flag vs the config option. I hope this makes sense.
I think I have fixed all the lints/tests. I added to the docs for the config command as well.
kvm2 driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 53.6s | 53.6s |
| enable ingress | 15.7s | 15.2s |
+----------------+----------+---------------------+
Times for minikube ingress: 16.1s 16.1s 15.7s 15.1s 15.2s Times for minikube (PR 21064) ingress: 15.1s 16.2s 14.7s 15.1s 14.6s
Times for minikube start: 53.6s 55.8s 54.3s 51.6s 52.5s Times for minikube (PR 21064) start: 54.4s 52.0s 54.0s 53.3s 54.2s
docker driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 24.2s | 24.1s |
| enable ingress | 13.1s | 12.7s |
+----------------+----------+---------------------+
Times for minikube (PR 21064) start: 23.0s 23.6s 23.3s 27.1s 23.4s Times for minikube start: 24.0s 23.4s 22.7s 23.9s 26.8s
Times for minikube ingress: 13.4s 13.3s 12.4s 13.3s 12.9s Times for minikube (PR 21064) ingress: 12.4s 12.3s 12.8s 13.4s 12.8s
docker driver with containerd runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 23.9s | 23.9s |
| enable ingress | 24.2s | 26.1s |
+----------------+----------+---------------------+
Times for minikube start: 23.8s 22.4s 25.3s 25.0s 23.0s Times for minikube (PR 21064) start: 23.8s 22.1s 26.9s 23.5s 23.2s
Times for minikube ingress: 22.8s 28.9s 22.9s 23.8s 22.8s Times for minikube (PR 21064) ingress: 22.9s 22.8s 38.8s 22.8s 22.9s
thank you @wt could you please
Put in the PR description, Before/After this PR what changes for the user?
and how is this different than setting "--dns-domain" ?
I think I have addressed this. Please let me know if more work is needed.
kvm2 driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 51.6s | 52.0s |
| enable ingress | 15.2s | 15.1s |
+----------------+----------+---------------------+
Times for minikube start: 48.1s 52.5s 51.0s 52.1s 54.3s Times for minikube (PR 21064) start: 50.8s 51.3s 52.9s 52.6s 52.3s
Times for minikube ingress: 15.1s 16.0s 16.0s 14.6s 14.5s Times for minikube (PR 21064) ingress: 15.0s 15.0s 15.0s 14.5s 16.0s
docker driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 23.0s | 24.0s |
| enable ingress | 12.7s | 13.1s |
+----------------+----------+---------------------+
Times for minikube start: 23.0s 22.4s 23.8s 23.7s 22.2s Times for minikube (PR 21064) start: 24.9s 23.5s 23.9s 23.4s 24.4s
Times for minikube ingress: 12.8s 13.8s 12.3s 12.3s 12.3s Times for minikube (PR 21064) ingress: 13.3s 13.8s 13.3s 13.3s 11.8s
docker driver with containerd runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 22.8s | 22.7s |
| enable ingress | 23.0s | 24.7s |
+----------------+----------+---------------------+
Times for minikube start: 24.2s 21.9s 22.2s 23.0s 22.5s Times for minikube (PR 21064) start: 20.1s 25.5s 25.4s 20.9s 21.3s
Times for minikube ingress: 22.8s 22.8s 23.8s 22.8s 22.8s Times for minikube (PR 21064) ingress: 32.3s 22.8s 21.8s 23.8s 22.8s
kvm2 driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 52.8s | 52.8s |
| enable ingress | 15.0s | 14.9s |
+----------------+----------+---------------------+
Times for minikube start: 51.9s 52.2s 51.9s 54.5s 53.6s Times for minikube (PR 21064) start: 52.3s 51.5s 53.2s 54.2s 52.8s
Times for minikube ingress: 15.0s 15.0s 15.1s 15.1s 15.0s Times for minikube (PR 21064) ingress: 15.0s 14.5s 15.0s 15.0s 15.1s
docker driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 23.5s | 24.3s |
| enable ingress | 12.8s | 12.4s |
+----------------+----------+---------------------+
Times for minikube start: 22.0s 23.1s 22.5s 22.4s 27.3s Times for minikube (PR 21064) start: 23.5s 25.6s 21.6s 27.1s 23.5s
Times for minikube ingress: 13.3s 12.8s 12.8s 12.3s 12.8s Times for minikube (PR 21064) ingress: 12.3s 12.8s 11.3s 12.3s 13.3s
docker driver with containerd runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 24.2s | 22.2s |
| enable ingress | 26.2s | 23.0s |
+----------------+----------+---------------------+
Times for minikube start: 26.1s 25.0s 24.2s 21.7s 23.8s Times for minikube (PR 21064) start: 20.7s 23.4s 21.7s 22.4s 23.1s
Times for minikube ingress: 22.8s 38.8s 22.8s 23.3s 23.3s Times for minikube (PR 21064) ingress: 23.3s 22.8s 22.8s 22.8s 23.3s
I am very confused by these test failures. I don't see how much change could have caused these failures. Do you have any suggestions for moving forward.
I am very confused by these test failures. I don't see how much change could have caused these failures. Do you have any suggestions for moving forward.
We have flaky test that fail all the time regardless of the change. It is also very hard to inspect the failures due to the excessive logging.
It is very handy to be able to store the default cluster dns name so that I can fire up and teardown clusters easily without losing that setting.
It's important to note that this default will only be applied at cluster creation time. If you have an existing cluster config, the name default name will not be changed if you added the config after starting the cluster the first time.
Isn't this the normal behavior for configs? If you create a cluster it uses defaults from the minikube config (e.g. number of cpus, number of disks, driver, container runtime). If the cluster exists we use the existing clusters so none of the configs modify it.
I don't fully understand the problem you are trying to solve, and why it cannot be solved with the existing --dns-domain option. Do we have an issue showing your use case? If not please open one showing the commands you are using when creating the clusters, and what is the issue you are trying to solve. In this PR you can show the same flow using the new config.
@nirs I don't want to have to remember to specify the --dns-domain flag every time I start a cluster the first time. The allows me to set my default in my config. With this config, my normal case of starting up a cluster is just minikube start. Without this config, I have to remember to run minikube start --dns-domain cluster.wt.users.dev.example.com, but only in the case where I am starting a my normal cluster config. This is literally a setting a default at the minikube level.
And...it appears to have the exact same semantics as some other settings. For example, by my reading of the code, the config option iso-url works exactly the same way. If you set that config, you get a default at cluster creation time. Setting that setting does not update an existing cluster, but there is a corresponding flag --iso-url that you can give during a creation or just restart. This is exactly the semantics that my change has.
kvm2 driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 52.2s | 50.4s |
| enable ingress | 14.8s | 15.4s |
+----------------+----------+---------------------+
Times for minikube start: 52.9s 52.6s 50.7s 49.8s 55.1s Times for minikube (PR 21064) start: 51.1s 50.9s 48.3s 50.9s 51.1s
Times for minikube ingress: 14.5s 15.0s 15.0s 14.5s 15.0s Times for minikube (PR 21064) ingress: 16.0s 16.0s 15.0s 15.0s 15.0s
docker driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 23.0s | 23.9s |
| enable ingress | 12.4s | 13.3s |
+----------------+----------+---------------------+
Times for minikube start: 23.8s 23.3s 21.6s 23.5s 23.0s Times for minikube (PR 21064) start: 22.3s 25.2s 23.7s 25.3s 23.1s
Times for minikube (PR 21064) ingress: 13.4s 12.8s 13.3s 13.8s 13.4s Times for minikube ingress: 11.3s 12.3s 12.3s 13.8s 12.3s
docker driver with containerd runtime
+-------------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+-------------------+----------+---------------------+
| minikube start | 24.0s | 22.6s |
| ⚠️ enable ingress | 23.0s | 31.1s ⚠️ |
+-------------------+----------+---------------------+
Times for minikube start: 24.1s 21.7s 24.3s 25.5s 24.5s Times for minikube (PR 21064) start: 21.3s 21.9s 21.9s 26.4s 21.5s
Times for minikube ingress: 22.8s 22.8s 22.8s 22.8s 23.8s Times for minikube (PR 21064) ingress: 27.8s 40.3s 23.9s 23.8s 39.8s
kvm2 driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 50.2s | 50.7s |
| enable ingress | 14.7s | 14.8s |
+----------------+----------+---------------------+
Times for minikube start: 46.4s 50.2s 50.9s 52.9s 50.5s Times for minikube (PR 21064) start: 50.6s 50.8s 48.7s 51.3s 52.0s
Times for minikube ingress: 14.5s 14.5s 15.0s 14.5s 15.0s Times for minikube (PR 21064) ingress: 15.1s 15.0s 15.0s 14.5s 14.5s
docker driver with docker runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 23.7s | 24.7s |
| enable ingress | 12.8s | 12.3s |
+----------------+----------+---------------------+
Times for minikube start: 25.3s 21.1s 24.0s 23.5s 24.6s Times for minikube (PR 21064) start: 23.0s 25.5s 23.3s 26.4s 25.4s
Times for minikube ingress: 13.3s 12.8s 12.3s 12.3s 13.3s Times for minikube (PR 21064) ingress: 12.3s 13.3s 12.3s 10.8s 12.8s
docker driver with containerd runtime
+----------------+----------+---------------------+
| COMMAND | MINIKUBE | MINIKUBE (PR 21064) |
+----------------+----------+---------------------+
| minikube start | 22.0s | 21.4s |
| enable ingress | 23.2s | 23.0s |
+----------------+----------+---------------------+
Times for minikube start: 21.8s 21.3s 20.7s 23.6s 22.8s Times for minikube (PR 21064) start: 20.7s 21.2s 21.4s 22.2s 21.7s
Times for minikube ingress: 23.3s 22.8s 23.8s 22.8s 23.3s Times for minikube (PR 21064) ingress: 22.8s 23.3s 22.8s 23.3s 22.8s
kvm2 driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 51.4s │ 50.5s │
│ enable ingress │ 15.0s │ 15.4s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 50.2s 53.2s 49.9s 50.5s 53.1s Times for minikube (PR 21064) start: 52.3s 49.9s 48.9s 51.9s 49.7s
Times for minikube ingress: 15.0s 15.0s 15.0s 15.0s 15.0s Times for minikube (PR 21064) ingress: 16.0s 15.9s 15.0s 14.9s 15.0s
docker driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.1s │ 23.2s │
│ enable ingress │ 13.2s │ 12.8s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube ingress: 12.8s 13.2s 13.2s 12.7s 13.8s Times for minikube (PR 21064) ingress: 10.2s 13.7s 13.7s 12.7s 13.8s
Times for minikube start: 21.0s 26.1s 25.4s 21.7s 26.4s Times for minikube (PR 21064) start: 22.6s 22.7s 24.3s 23.0s 23.5s
docker driver with containerd runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.6s │ 22.1s │
│ enable ingress │ 32.7s │ 26.2s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 20.4s 22.9s 21.4s 21.7s 21.7s Times for minikube (PR 21064) start: 23.5s 22.0s 22.4s 22.0s 20.6s
Times for minikube ingress: 22.7s 38.8s 22.8s 40.2s 39.2s Times for minikube (PR 21064) ingress: 39.8s 22.8s 22.7s 22.7s 22.7s
please put before/after this PR with full example to point out what is changing in this PR exactly and why do we need this
I already add a Before/After section to the commit message of the PR. Can you please help me understand what is missing from the description? Do you want me to put a commandline sequence and describe the difference like I did above the Before/After sections?
@medyagh I added a bunch of before/after context. I think this addresses your latest comment. Please let me know if more is needed.
kvm2 driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 53.3s │ 52.5s │
│ enable ingress │ 15.9s │ 16.8s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 56.7s 50.2s 55.3s 50.6s 53.7s Times for minikube (PR 21064) start: 53.2s 51.8s 52.2s 51.8s 53.5s
Times for minikube ingress: 15.6s 17.6s 16.1s 15.0s 15.1s Times for minikube (PR 21064) ingress: 19.6s 14.6s 18.6s 16.1s 15.1s
docker driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.5s │ 25.5s │
│ enable ingress │ 13.0s │ 13.3s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 23.4s 23.7s 23.9s 23.9s 22.8s Times for minikube (PR 21064) start: 27.0s 24.5s 26.1s 26.7s 23.1s
Times for minikube ingress: 12.8s 13.3s 13.3s 12.3s 13.3s Times for minikube (PR 21064) ingress: 13.3s 13.3s 13.8s 13.4s 12.8s
docker driver with containerd runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.1s │ 24.2s │
│ enable ingress │ 22.8s │ 26.2s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 23.6s 21.5s 22.5s 24.7s 23.0s Times for minikube (PR 21064) start: 24.9s 22.5s 22.6s 25.5s 25.5s
Times for minikube ingress: 22.8s 22.8s 22.8s 22.8s 22.8s Times for minikube (PR 21064) ingress: 38.8s 22.8s 23.8s 22.8s 22.8s
kvm2 driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 52.2s │ 51.0s │
│ enable ingress │ 14.9s │ 15.0s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 53.1s 48.5s 55.1s 52.6s 51.8s Times for minikube (PR 21064) start: 51.1s 46.9s 49.1s 53.7s 54.5s
Times for minikube ingress: 15.0s 15.0s 15.0s 15.0s 14.5s Times for minikube (PR 21064) ingress: 15.0s 14.9s 16.0s 14.5s 14.5s
docker driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.0s │ 23.6s │
│ enable ingress │ 13.0s │ 12.6s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 25.2s 24.4s 23.6s 25.4s 21.7s Times for minikube (PR 21064) start: 22.3s 22.1s 25.3s 26.3s 22.0s
Times for minikube ingress: 13.3s 12.8s 13.3s 12.8s 12.8s Times for minikube (PR 21064) ingress: 10.8s 13.3s 13.8s 13.3s 11.8s
docker driver with containerd runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.7s │ 23.4s │
│ enable ingress │ 26.0s │ 23.6s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube ingress: 22.8s 22.8s 22.8s 38.8s 22.8s Times for minikube (PR 21064) ingress: 22.8s 26.8s 22.8s 22.8s 22.8s
Times for minikube start: 21.3s 21.8s 23.7s 22.6s 24.2s Times for minikube (PR 21064) start: 22.4s 25.5s 25.7s 23.0s 20.4s
commit
the Before/After Description is most useful in the PR Description for the reviwer and also in the changelog for the users to click on PRs to see what a PR is about, we dont utilize commit messages to be Long format, I prefer commit messages to be short and relevant to the commit and any other extra info should be in the PR Description
commit
the Before/After Description is most useful in the PR Description for the reviwer and also in the changelog for the users to click on PRs to see what a PR is about, we dont utilize commit messages to be Long format, I prefer commit messages to be short and relevant to the commit and any other extra info should be in the PR Description
The PR message is hard to find when inspecting git history later, so all important content should be accessible git log. The PR message can be a copy of the commit message or add more details when we have multiple commits.
In this case the commit message looks very good (but I did not ready it yet), but the PR mesage is not helpful. @wt you can copy the commit message to the PR message to help reviewers.
I updated the original PR message to match the current commit message. I didn't realize you wanted me to change that before. Thanks for spelling that out.
FWIW, I have had some time to think about this change a bit more. I realized that a more powerful version of this change's idea might allow one to config only the .local part of the domain name.
This can be added on top of this change. I do not think that the scope of this change should be expanded to include this. I just wanted to see if y'all had any thoughts on this.
kvm2 driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 51.2s │ 50.8s │
│ enable ingress │ 15.7s │ 14.9s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 49.9s 52.2s 52.2s 50.3s 51.5s Times for minikube (PR 21064) start: 51.1s 49.2s 48.8s 53.6s 51.2s
Times for minikube ingress: 16.0s 18.0s 14.5s 15.0s 15.0s Times for minikube (PR 21064) ingress: 15.0s 15.1s 15.0s 14.4s 14.9s
docker driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.7s │ 24.8s │
│ enable ingress │ 13.3s │ 12.6s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 26.1s 26.3s 22.3s 25.4s 23.5s Times for minikube (PR 21064) start: 25.6s 25.2s 23.4s 23.5s 26.4s
Times for minikube ingress: 13.8s 12.7s 13.8s 13.3s 12.7s Times for minikube (PR 21064) ingress: 13.7s 12.7s 12.3s 10.7s 13.3s
docker driver with containerd runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.4s │ 22.7s │
│ enable ingress │ 27.6s │ 27.4s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube ingress: 28.8s 22.7s 38.8s 24.3s 23.2s Times for minikube (PR 21064) ingress: 22.8s 22.7s 28.0s 23.2s 40.3s
Times for minikube start: 20.7s 21.4s 21.0s 25.0s 24.1s Times for minikube (PR 21064) start: 21.6s 21.7s 25.8s 22.5s 21.9s
kvm2 driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 51.8s │ 52.1s │
│ enable ingress │ 15.1s │ 15.1s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube ingress: 15.0s 15.5s 14.5s 15.0s 15.5s Times for minikube (PR 21064) ingress: 15.0s 15.0s 14.5s 15.0s 16.1s
Times for minikube start: 53.1s 52.1s 48.9s 52.1s 52.8s Times for minikube (PR 21064) start: 53.2s 51.8s 51.5s 51.0s 52.8s
docker driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.5s │ 25.9s │
│ enable ingress │ 11.9s │ 12.8s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 21.7s 22.7s 25.4s 24.7s 22.9s Times for minikube (PR 21064) start: 26.2s 26.3s 25.6s 25.3s 26.2s
Times for minikube ingress: 12.3s 10.3s 12.3s 12.3s 12.3s Times for minikube (PR 21064) ingress: 12.8s 13.3s 12.3s 12.8s 12.8s
docker driver with containerd runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21064 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.8s │ 22.9s │
│ enable ingress │ 24.4s │ 26.2s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 24.7s 23.7s 20.8s 20.6s 24.1s Times for minikube (PR 21064) start: 24.9s 21.6s 23.5s 21.1s 23.3s
Times for minikube ingress: 23.2s 23.3s 29.3s 23.3s 22.8s Times for minikube (PR 21064) ingress: 38.7s 22.8s 22.8s 23.3s 23.3s