kubernetes icon indicating copy to clipboard operation
kubernetes copied to clipboard

Add network packet stats in kubelet Summary API

Open CatherineF-dev opened this issue 3 years ago • 9 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Summary API stats don't have network packet related stats. Those metrics are important for monitoring network.

Which issue(s) this PR fixes:

Fixes #109837

  • Add packet stats in Summary API
  • Expose packet stats using cAdvisor

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add these four network packet stats in Summary API, which have values when using cAdvisor.
- RxPackets: Cumulative count of packets received
- RxDropped: Cumulative count of packets dropped while receiving
- TxPackets:  Cumulative count of packets transmitted
- TxDropped: Cumulative count of packets dropped while transmitting

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


CatherineF-dev avatar May 05 '22 19:05 CatherineF-dev

@CatherineF-dev: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 05 '22 19:05 k8s-ci-robot

/test pull-kubernetes-node-e2e-containerd

CatherineF-dev avatar May 06 '22 16:05 CatherineF-dev

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CatherineF-dev To complete the pull request process, please assign mrunalp after the PR has been reviewed. You can assign the PR to them by writing /assign @mrunalp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 06 '22 16:05 k8s-ci-robot

/retest I think this needs a release note.

matthyx avatar May 09 '22 06:05 matthyx

Added, thx!


Hi team,

does anyone know where is the release note? Plan to add it to release note if it's approved.

CatherineF-dev avatar May 12 '22 02:05 CatherineF-dev

Thanks @CatherineF-dev I hope we can triage this soon during the next meeting!

matthyx avatar May 13 '22 12:05 matthyx

/cc @bobbypage

endocrimes avatar May 25 '22 16:05 endocrimes

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 23 '22 17:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 22 '22 17:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Oct 22 '22 18:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 22 '22 18:10 k8s-ci-robot