kubectl icon indicating copy to clipboard operation
kubectl copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Warn about a possible conflict using `kubectl rollout undo` when a last applied annotation is present

Open sftim opened this issue 3 years ago • 6 comments
trafficstars

What would you like to be added: kubectl rollout undo doesn't revert the kubectl.kubernetes.io/last-applied-configuration annotation, which leads to problems if named objects in arrays are intended to be removed.

Add a warning to kubectl rollout undo that is printed if that annotation is present on the Deployment (or other object) being rolled back.

Why is this needed: kubectl rollout undo does not pair well with kubectl client side apply.

This is an interim approach; maybe one day we'll have a better fix for:

  • https://github.com/kubernetes/kubectl/issues/1301
  • https://github.com/kubernetes/kubectl/issues/1297

sftim avatar Oct 12 '22 16:10 sftim

@sftim: This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 12 '22 16:10 k8s-ci-robot

This issue is heavily based on https://github.com/kubernetes/kubectl/issues/1301#issuecomment-1276427839

sftim avatar Oct 12 '22 16:10 sftim

@seans3 FYI

sftim avatar Oct 12 '22 16:10 sftim

/triage accepted /priority backlog

eddiezane avatar Dec 07 '22 17:12 eddiezane

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Jan 19 '24 18:01 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 18 '24 18:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 18 '24 18:05 k8s-triage-robot