feat(nestedArray): parsing * on array of array
What this PR does / why we need it: Enable parsing nested arrays.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
We can now write this kind of path: "status", "parents", "[*]", "conditions".
Where [*]means listing all the parents object inside the list.
Which issue(s) this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)
Fixes #2368
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: raf262 / name: Raphaël LOUSSINIAN (23e6357967e37bde7b58c99d0675c7e5b21ce6b9, 44788f2ca5c8097c40dfa76962b3100a48040b74, abddd3e77800cd859e708c28474267c23038ee4f, cf5c7980cdb45d722b8ec0412e24762959362bfe, dd517770809ddab5effa47e756d097646e08e94a, e287bd6e80e5e32e8f118322899b26974bd2c3b3, e33f89efe37969149458ea148b963ef8f08119a7, f08aebf80a498a49bb1bde431377e78551fd32b7, f3c12f45bd7f7a3166a635f193a34eadd4dd6e4f)
Welcome @raf262!
It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: raf262, yannchabed Once this PR has been reviewed and has the lgtm label, please assign rexagod for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi everyone, I don't know if this PR is missing something, please tell me. If it needs reword I'm available !
@mrueg maybe you have some times to review it ?
Thanks guys
/triage accepted /assign @rexagod