kube-state-metrics icon indicating copy to clipboard operation
kube-state-metrics copied to clipboard

chore: Replace gojsontoyaml with gojq

Open mrueg opened this issue 7 months ago • 10 comments

What this PR does / why we need it: https://github.com/brancz/gojsontoyaml hasn't had a commit since 4 years +, replace it with a maintained alternative.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) None Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

mrueg avatar Apr 23 '25 21:04 mrueg

/lgtm /hold

To give time to other discussion(s) here, feel free to unhold.

rexagod avatar Apr 29 '25 18:04 rexagod

/triage accepted

richabanker avatar May 01 '25 16:05 richabanker

/lgtm /hold

Feel free to unhold

CatherineF-dev avatar Jun 20 '25 00:06 CatherineF-dev

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, mrueg, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [CatherineF-dev,mrueg,rexagod]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 20 '25 00:06 k8s-ci-robot

@mrueg need to resync

CatherineF-dev avatar Aug 13 '25 17:08 CatherineF-dev

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Aug 14 '25 07:08 k8s-ci-robot

@CatherineF-dev @rexagod @dgrisonnet let me know if you're good with that change.

mrueg avatar Aug 21 '25 16:08 mrueg

@rexagod @CatherineF-dev can I get a review on this?

mrueg avatar Sep 15 '25 09:09 mrueg

/hold cancel @rexagod @dgrisonnet @CatherineF-dev can I get another review here? Thanks!

mrueg avatar Sep 29 '25 10:09 mrueg

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 09 '25 11:10 k8s-ci-robot