kube-state-metrics icon indicating copy to clipboard operation
kube-state-metrics copied to clipboard

docs: update doc around fetching unscheduled pods using --node=

Open CatherineF-dev opened this issue 1 year ago • 4 comments

What this PR does / why we need it:

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) n/a

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes/kube-state-metrics/issues/2353

CatherineF-dev avatar Apr 03 '24 12:04 CatherineF-dev

/assign

dgrisonnet avatar Apr 04 '24 16:04 dgrisonnet

/triage accepted

dgrisonnet avatar Apr 04 '24 16:04 dgrisonnet

Sorry, I forgot: The change needs to be made in README.md.tpl and then you'd need to run the make target to regenerate the README file with gomplate.

mrueg avatar Apr 11 '24 19:04 mrueg

Let's add this once https://github.com/kubernetes/kube-state-metrics/pull/2388 is in.

We can refactor the behavior later.

mrueg avatar May 16 '24 20:05 mrueg

/lgtm

LaikaN57 avatar Jun 06 '24 09:06 LaikaN57

@LaikaN57: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 06 '24 09:06 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CatherineF-dev, LaikaN57 Once this PR has been reviewed and has the lgtm label, please ask for approval from dgrisonnet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 06 '24 09:06 k8s-ci-robot

This PR is not needed due to https://github.com/kubernetes/kube-state-metrics/pull/2388

CatherineF-dev avatar Jun 13 '24 22:06 CatherineF-dev