kube-openapi

kube-openapi copied to clipboard

Add support for common name formats to validation markers

7

Schnides123

feature: Allow validation comment tags to be merged through aliases

5

We have a number of shared Go types used in k8s API. It would be useful if we could use aliases to override validation of a base type without creating...

alexzielenski

OpenAPI Gen should fail for invalid x-kubernetes-map-type/keys/etc combinations

7

See https://github.com/kubernetes/kubernetes/pull/114585, We've been able to generate a bogus OpenAPI with `x-kubernetes-list-type=set` for a list of non-atomic maps. And we haven't been able to detect that until after the type...

apelisse

Having the same type embedded more than once breaks generation

5

`ServiceServingCertSignerConfig` embeds `metav1.TypeMeta` and `configv1.GenericControllerConfig`: https://github.com/openshift/api/blob/master/servicecertsigner/v1alpha1/types.go#L15-L21 At the time, `configv1.GenericControllerConfig` also embedded `metav1.TypeMeta`, which led to: ``` func schema_openshift_api_servicecertsigner_v1alpha1_ServiceServingCertSignerConfig(ref common.ReferenceCallback) common.OpenAPIDefinition { return common.OpenAPIDefinition{ Schema: spec.Schema{ SchemaProps: spec.SchemaProps{ Description: "ServiceServingCertSignerConfig...

enj

Fix FilterSpecByPathsWithoutSideEffects to handle cases without slash

2

The current FilterSpecByPathsWithoutSideEffects behavior is wrong for paths without a trailing slash. See comment thread for more details: https://github.com/kubernetes/kubernetes/pull/123770/files#r1516319191 cc @liggitt

Jefftree

build(deps): bump github.com/getkin/kin-openapi from 0.103.0 to 0.126.0 in /test/integration

1

Bumps [github.com/getkin/kin-openapi](https://github.com/getkin/kin-openapi) from 0.103.0 to 0.126.0. Release notes Sourced from github.com/getkin/kin-openapi's releases. v0.126.0 What's Changed openapi3: document v0.124.0 breaking API changes by @​percivalalb in getkin/kin-openapi#964 openapi3: introduce ReferencesComponentInRootDocument(doc *T, ref...

dependabot[bot]

int or string prototype [WIP]

3

Prototype of adding x-int-or-string See https://github.com/kubernetes/kubernetes/pull/125612 for generation

Jefftree

Render code blocks properly in OpenAPI

11

Render code blocks properly in OpenAPI. Partially solves https://github.com/kubernetes/website/issues/35712 /cc @sftim @robert-cronin /assign @jpbetz @sttts k/k OpenAPI diff can be seen here https://github.com/kubernetes/kubernetes/pull/125899/commits/7e24dabdd9b84c67f2f2aa1445d53be6bddefb7e#diff-9f4c1466e676f9e733cae72d369ffd5ff37f446116c98562807cf3bfb872ae95

Jefftree

Add k8s name related formats

28

This adds the three most heavily used name formats in k8s: - k8s.io/dns-1035-label - k8s.io/dns-1035-label-prefix - k8s.io/dns-1123-label - k8s.io/dns-1123-label-prefix - k8s.io/dns-1123-subdomain - k8s.io/dns-1123-subdomain-prefix Note: These formats implemented in k8s in...

jpbetz

OpenAPI V3 references parsed as *proto.Arbitrary instead of *proto.Ref

3

# The issue I'm using [proto.NewOpenAPIV3Data()](https://github.com/kubernetes/kube-openapi/blob/835d969ad83aca3ef62637b255332df649856429/pkg/util/proto/document_v3.go#L30) to parse an OpenAPI V3 spec coming from the `/openapi/v3` endpoints of the apiserver. I'd expect fields such as `.metadata.ownerReferences` to be a [*proto.Ref](https://github.com/kubernetes/kube-openapi/blob/835d969ad83aca3ef62637b255332df649856429/pkg/util/proto/document.go#L339)...

tomleb