kops icon indicating copy to clipboard operation
kops copied to clipboard

WIP: Scaleway init dns

Open Mia-Cross opened this issue 3 years ago • 8 comments

Adding support for Scaleway: Step 1: DNS

Mia-Cross avatar Jul 15 '22 16:07 Mia-Cross

Welcome @Mia-Cross!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 15 '22 16:07 k8s-ci-robot

Hi @Mia-Cross. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 15 '22 16:07 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Mia-Cross (95324223960d9c602f22c9dc073c4409fe097005, fde6cca05c5bb391af3723604e2cd2b3d6b0d18e, 39d00df8db4b45876e82e8d92b9fc5a5819389a3, 3c690d93b2861d8ef1c3e6dd76da98692152aeb2, 135ec80d04885510e6b6ae436a93589dc40f6267, 387fb216bdb524b672a8ad2cb676fc57592da76c, eb660367a5818feaf762451144fcad38f2a85308, 93a16ccc30efbd5d5d29dbd6728e7698f7b7e492, 43dc5e9eb6ec52b3c04d87000cee38df2d0c59e1, b6f5d3fea0a687779725ff9f2a7c25da44cb3067, 3cd7ab5ed01d24ffe648c4e7a821adfde6e69d5d, 117fcbdb2080f645ef0c5c0dcaf985842bdf1c30, 174941af7dad258070db65876f55a553c7fabf4f, 4ad9830a76843fc83b23897638122086449757a1, ef8bec130203868ed0ea425b415ffd2d45edde14)

/ok-to-test

hakman avatar Jul 15 '22 16:07 hakman

@Mia-Cross: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 22 '22 08:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval by writing /assign @olemarkus in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 22 '22 08:07 k8s-ci-robot

@Mia-Cross: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 12 '22 11:08 k8s-ci-robot

@Mia-Cross: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-verify-boilerplate 139e9d660c1c7367d753128e33975bf7de2d313e link true /test pull-kops-verify-boilerplate
pull-kops-verify-govet 139e9d660c1c7367d753128e33975bf7de2d313e link true /test pull-kops-verify-govet
pull-kops-verify-gomod 139e9d660c1c7367d753128e33975bf7de2d313e link true /test pull-kops-verify-gomod
pull-kops-verify-golangci-lint 139e9d660c1c7367d753128e33975bf7de2d313e link true /test pull-kops-verify-golangci-lint
pull-kops-e2e-kubernetes-aws 139e9d660c1c7367d753128e33975bf7de2d313e link true /test pull-kops-e2e-kubernetes-aws
pull-kops-e2e-k8s-gce-cilium ef8bec130203868ed0ea425b415ffd2d45edde14 link true /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-aws-karpenter ef8bec130203868ed0ea425b415ffd2d45edde14 link true /test pull-kops-e2e-aws-karpenter
pull-kops-e2e-k8s-aws-calico ef8bec130203868ed0ea425b415ffd2d45edde14 link true /test pull-kops-e2e-k8s-aws-calico
pull-kops-build ef8bec130203868ed0ea425b415ffd2d45edde14 link true /test pull-kops-build
pull-kops-test ef8bec130203868ed0ea425b415ffd2d45edde14 link true /test pull-kops-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Aug 31 '22 07:08 k8s-ci-robot

/check-cla /easycla

hakman avatar Sep 01 '22 09:09 hakman

This pull request is starting to get old and I'm instead going to make several smaller ones so I should close it.

Mia-Cross avatar Sep 23 '22 16:09 Mia-Cross