kubernetes
Parameterize metrics port name
@anders-swanson: This issue is currently awaiting triage.
If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @anders-swanson. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Reverting is nice but why not just create a variable instead? I think all we need to do is to call it:
Values.controller.metrics.service.name and set the default value to metrics?
Then it should work for all of us straight away.
I saw your comment in the issue and you wanted to fix that in a separate PR. Thanks for the quick action @anders-swanson LGTM
I can fix in this PR. Was not sure if it was desirable to revert first and then fix. Like you say it is a simple fix, I already have done it on my local branch.
Yeah from my point of view why not fix it straight away. Let's see if the maintainers agree :) LGTM
I don't think there is anything pending from your side. But we have to make a release now with a couple of really important and needed changes. So the approvers will look at this as soon some higher priority work allows them time. This change should become available with the next releae that I mentioned.
cc @tao12345666333 @strongjz @rikatz
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: anders-swanson, longwuyuan, strongjz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~charts/ingress-nginx/OWNERS~~ [strongjz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment