ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

Add support to make delay, size, burst configurable in limit_req directive

Open bmv126 opened this issue 3 years ago • 6 comments

In current code below is the behaviour for limit_req and limit_req_zone directives : a) burst is always set even if user does not need it. b) delay is always set to nodelay. c) zone size is not configurable and set to 5m.

In nginx delay and burst are optional.
http://nginx.org/en/docs/http/ngx_http_limit_req_module.html#limit_req

This commit adds support to make delay, zone size configurable and also make burst optional.

Below annotations are added to support it:

nginx.ingress.kubernetes.io/limit-no-burst : Bool (Default: false) 
nginx.ingress.kubernetes.io/limit-delay: Int (Default: -1)
nginx.ingress.kubernetes.io/limit-shared-size: Int (Default: 5) 

bmv126 avatar Sep 11 '22 16:09 bmv126

CLA Not Signed

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmv126 Once this PR has been reviewed and has the lgtm label, please assign strongjz for approval by writing /assign @strongjz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 11 '22 16:09 k8s-ci-robot

@bmv126: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 11 '22 16:09 k8s-ci-robot

Welcome @bmv126!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 11 '22 16:09 k8s-ci-robot

Hi @bmv126. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 11 '22 16:09 k8s-ci-robot

Hi, you a need to sign the CLA so that the PR can be approved, after signing the CLA just run the command "/easycla", so the status is refreshed. If you find any kind of problem take a look at the CLA tutorial.

DanielViniciusAlves avatar Sep 15 '22 14:09 DanielViniciusAlves

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 14 '22 14:12 k8s-triage-robot

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit 86f3af8dead82f2d0905dceddeba213751e15b50
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65d095bbf947150008576137

netlify[bot] avatar Jul 13 '23 08:07 netlify[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 22 '23 12:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmv126

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 17 '24 11:02 k8s-ci-robot