Allow filtering request handling dashboard on exported_namespace

[deepy]

What this PR does / why we need it:

The request handling dashboard is great but gets messy if you're deploying the same application in multiple namespaces and you're not able to change the name of the ingress resource In my case I have ingresses named after their application in multiple namespaces, i.e. httpbin-ingress might exist in the namespaceshttpbin-prod, httpbin-staging and httpbin-dev This PR adds namespace as a variable for filtering to allow you to narrow down the data prevented in the dashboard further

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] CVE Report (Scanner found CVE and adding report)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Documentation only

How Has This Been Tested?

I've tested this on grafana cloud, and on a Grafana instance created following the ingress-nginx documentation

Checklist:

• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I've read the CONTRIBUTION guide
• [ ] I have added unit and/or e2e tests to cover my changes.
• [ ] All new and existing tests passed.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: deepy / name: Alex Nordlund (e514c2fbe78fd03e1951a8c9b7f5098c29583e01)

[k8s-ci-robot]

Welcome @deepy!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @deepy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

Lovely. Please add screenshots of drop-down and views here. Please sign cla

On Wed, 7 Jun, 2023, 7:14 pm Kubernetes Prow Robot, < @.***> wrote:

Hi @deepy https://github.com/deepy. Thanks for your PR.

I'm waiting for a kubernetes https://github.com/orgs/kubernetes/people member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org https://git.k8s.io/community/community-membership.md#member to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here https://go.k8s.io/bot-commands?repo=kubernetes%2Fingress-nginx.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/guide/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/ingress-nginx/pull/10052#issuecomment-1580856015, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGZVWWT2YSH33GHIFKVEZTXKCAVXANCNFSM6AAAAAAY54Y2PA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[deepy]

Done

[longwuyuan]

Awesome. Thanks for the contribution. /ok-to-test /triage accepted

cc @rikatz @strongjz

On Wed, 7 Jun, 2023, 7:28 pm Alex Nordlund, @.***> wrote:

Done

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/ingress-nginx/pull/10052#issuecomment-1580881810, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGZVWU7Q5J2YULEBZPBPP3XKCCGZANCNFSM6AAAAAAY54Y2PA . You are receiving this because you commented.Message ID: @.***>

[longwuyuan]

cc @cpanato @tao12345666333

On Wed, 7 Jun, 2023, 7:31 pm Yuan, @.***> wrote:

Awesome. Thanks for the contribution. /ok-to-test /triage accepted

cc @rikatz @strongjz

On Wed, 7 Jun, 2023, 7:28 pm Alex Nordlund, @.***> wrote:

Done

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/ingress-nginx/pull/10052#issuecomment-1580881810, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGZVWU7Q5J2YULEBZPBPP3XKCCGZANCNFSM6AAAAAAY54Y2PA . You are receiving this because you commented.Message ID: @.***>

[tao12345666333]

Thanks, let me take a look

[tao12345666333]

/assign

[tao12345666333]

As an extra note, can you add information about your test environment to the description? This saves a lot of time.

if you're deploying the same application in multiple namespaces

I noticed your sentence, please add information to avoid my misunderstanding, thanks

[deepy]

I'll add another line to clarify that one, but in essence if you have two ingress with the same name but in different namespaces The dashboards will correctly show the hostname, but if I have more than 10 ingresses that may be too much data to consume easily

[tao12345666333]

So your point is, as long as I deploy ingress-controllers with the same name in different namespaces and collect their metrics, I can perform verification, right?

[tao12345666333]

Maybe I misunderstood, are you referring to Ingress resources instead of ingress-controller?

To make it clearer, could you please list the verification steps directly?

[deepy]

Yes, this is only for the request handling dashboard, i.e. not for the controller itself.

Easiest way to test this is to create two namespaces, prod and dev and create an ingress resource called httpbin in both Service Ingress variable in the dashboard will show a single ingress (httpbin) and Ingress Namespace variable will show two (prod and dev)

[github-actions[bot]]

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

[k8s-triage-robot]

The lifecycle/frozen label can not be applied to PRs.

This bot removes lifecycle/frozen from PRs because:

• Commenting /lifecycle frozen on a PR has not worked since March 2021
• PRs that remain open for >150 days are unlikely to be easily rebased

You can:

• Rebase this PR and attempt to get it merged
• Close this PR with /close

Please send feedback to sig-contributor-experience at kubernetes/community.

/remove-lifecycle frozen

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rikatz]

/lgtm /approve

Please rebase and we shall get this merged. Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepy, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [rikatz]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@deepy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pre-ingress-nginx-lua-test	e514c2fbe78fd03e1951a8c9b7f5098c29583e01	link	true	/test pre-ingress-nginx-lua-test
pre-ingress-nginx-codegen	e514c2fbe78fd03e1951a8c9b7f5098c29583e01	link	true	/test pre-ingress-nginx-codegen
pre-ingress-nginx-boilerplate	e514c2fbe78fd03e1951a8c9b7f5098c29583e01	link	true	/test pre-ingress-nginx-boilerplate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.