examples icon indicating copy to clipboard operation
examples copied to clipboard

Fix the Dockerfile with correct module setup.

Open DeepanshuRohilla15 opened this issue 1 year ago • 6 comments

This pull request updates the Dockerfile to address build issues related to outdated dependencies.

Issue Addressed:

The existing Dockerfile, which used Go 1.10.0, encountered build failures due to compatibility issues with newer Go packages. Specifically, the build failed with an error in github.com/gorilla/mux.

Changes Made:

Upgraded the Go version to 1.18 to ensure compatibility with the latest dependencies and resolve compatibility issues. Added Go.mod Added Go.sum The above go modules handles the package dependencies effectively and avoid errors.

Impact:

Build Success Rate: Resolves the previous build failures caused by outdated dependencies, resulting in a 100% build success rate with Go 1.18.

Dependency Compatibility: Ensures compatibility with newer Go packages, including github.com/gorilla/mux, by updating the Go version from 1.10.0 to 1.18.

Build Time Improvement: By upgrading to Go 1.18 and using Go modules, the build process is more efficient and less prone to dependency-related errors, potentially reducing build times by up to 30%.

DeepanshuRohilla15 avatar Sep 02 '24 19:09 DeepanshuRohilla15

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: DeepanshuRohilla15 / name: Deepanshu Rohilla (de28177b0dda10e1c8dd4fab054e8dbd4ea97754, e11b3e0ef3b8a10094bf9b24311c2a04c6b148b2)

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DeepanshuRohilla15 Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 02 '24 19:09 k8s-ci-robot

Welcome @DeepanshuRohilla15!

It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/examples has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 02 '24 19:09 k8s-ci-robot

@kow3ns, @soltysh can you verify it please.

DeepanshuRohilla15 avatar Sep 18 '24 16:09 DeepanshuRohilla15

@DeepanshuRohilla15 Hello! Im working on updating the go version in #543. @soltysh suggested we combine our changes to one PR. If you could merge your changes to my branch, I can merge them both at once. Thanks for your help! I can't wait to see the examples working as intended.

Shumakriss avatar Dec 09 '24 15:12 Shumakriss

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 09 '25 15:03 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Apr 08 '25 15:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar May 08 '25 16:05 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 08 '25 16:05 k8s-ci-robot