enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

DRA: Prioritized Alternatives in Device Requests

Open klueska opened this issue 1 year ago • 48 comments
trafficstars

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add support for a "one-of" prioritized list of selection criteria to satisfy a device request in a resource claim.

  • Kubernetes Enhancement Proposal:

    • https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/4816-dra-prioritized-list/README.md
  • Discussion Link:

    • https://github.com/kubernetes-sigs/wg-device-management/blob/0ec4f1ca783e550933de01533b7fb7b7ab14defb/dra-evolution/pkg/api/claim_types.go#L201-L208
  • Primary contact (assignee): @klueska, @pohly, @johnbelamaric, @thockin

  • Responsible SIGs: /sig scheduling /sig node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target: 1.33
    • Beta release target: 1.34
    • Stable release target: 1.35
  • [ ] Alpha

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4871
      • https://github.com/kubernetes/enhancements/pull/5065
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/128586
    • [ ] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/48516
  • [ ] Beta

    • [ ] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/5261
    • [ ] Code (k/k) update PR(s):
      • TBD
    • [ ] Docs (k/website) update(s):
      • TBD

klueska avatar Aug 30 '24 09:08 klueska

/sig node /wg device-management

kannon92 avatar Aug 30 '24 11:08 kannon92

@kannon92: The label(s) wg/device-management cannot be applied, because the repository doesn't have them.

In response to this:

/sig node /wg device-management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 30 '24 11:08 k8s-ci-robot

/milestone v1.32 /label lead-opted-in

haircommander avatar Sep 17 '24 18:09 haircommander

/retitle DRA: Prioritized List of Devices

just slightly shorter

johnbelamaric avatar Sep 24 '24 14:09 johnbelamaric

It's not listing "devices"? How about "DRA: alternatives in device requests"?

pohly avatar Sep 24 '24 15:09 pohly

It's not listing "devices"? How about "DRA: alternatives in device requests"?

Yes, sure, except I want the "prioritized" part in there.

/retitle DRA: Prioritized List of Device Requests

johnbelamaric avatar Sep 24 '24 15:09 johnbelamaric

actually, one more time:

/retitle DRA: Prioritized Alternatives in Device Requests

johnbelamaric avatar Sep 24 '24 15:09 johnbelamaric

Hello @klueska @johnbelamaric 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.32.
  • [ ] KEP readme has up-to-date graduation criteria

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

shecodesmagic avatar Sep 25 '24 00:09 shecodesmagic

@shecodesmagic I unchecked the PRR box - I am a PRR approver but shouldn't approve my own KEP. I haven't done the PRR section yet. I assigned @jpbetz to do the PRR for me.

johnbelamaric avatar Sep 25 '24 12:09 johnbelamaric

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

shecodesmagic avatar Oct 11 '24 02:10 shecodesmagic

Hi @johnbelamaric 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

chanieljdan avatar Oct 12 '24 02:10 chanieljdan

Hi @johnbelamaric :wave:,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs.

The deadline for this is Thursday Oct 24 at 18:00 PDT.

Thanks

James Spurin

spurin avatar Oct 18 '24 11:10 spurin

Hi @johnbelamaric,

Hope all is well. Quick followup to remind you we'll need at least a placeholder PR for documentation against the dev-1.32 branch. The deadline is tomorrow (Thursday Oct 24 at 18:00 PDT).

cc: @chanieljdan @katcosgrove

Thanks

James Spurin

spurin avatar Oct 23 '24 12:10 spurin

@spurin placeholder is https://github.com/kubernetes/website/pull/48516

Not sure this will make the release, but hopefully.

johnbelamaric avatar Oct 23 '24 14:10 johnbelamaric

👋 Hi there, William here from v1.32 Comms We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

wrkode avatar Oct 24 '24 16:10 wrkode

Hello @johnbelamaric @klueska, Enhancements team here (again 😁 )

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024. All PRs to the Kubernetes repo that are related to your enhancement need to be linked in the above issue description (for tracking purposes). Please update the issue description accordingly.

I was not able to find the PRs (code changes) related to this enhancements. All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests. I will mark this enhancement as at risk for code freeze for the v1.32 Code Freeze!

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

shecodesmagic avatar Oct 30 '24 01:10 shecodesmagic

Hello @johnbelamaric @klueska, 👋 v1.32 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.32 milestone.

If you still wish to progress this enhancement in v1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/label tracked/no /milestone clear

dipesh-rawat avatar Nov 08 '24 02:11 dipesh-rawat

/wg device-management

pohly avatar Nov 19 '24 16:11 pohly

/sig scheduling

alculquicondor avatar Jan 09 '25 18:01 alculquicondor

/label lead-opted-in

alculquicondor avatar Jan 09 '25 18:01 alculquicondor

/milestone v1.33

alculquicondor avatar Jan 09 '25 18:01 alculquicondor

Hello @johnbelamaric 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.33.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • Please change the latest-milestone and alpha milestone of kep.yml to v1.33.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

bianbbc87 avatar Feb 04 '25 17:02 bianbbc87

PRR reviewer here. Is there a KEP update PR available for review for this enhancement? Deadline is TOMORROW.

jpbetz avatar Feb 05 '25 22:02 jpbetz

PRR reviewer here. Is there a KEP update PR available for review for this enhancement? Deadline is TOMORROW.

I think the KEP went in for 1.32 already. The implementation slipped to 1.33.

@johnbelamaric Will there will be a KEP update for this feature?

kannon92 avatar Feb 05 '25 22:02 kannon92

PRR from 1.32 is still valid, nothing changed that is production readiness related.

johnbelamaric avatar Feb 05 '25 22:02 johnbelamaric

I believe this is all completed in https://github.com/kubernetes/enhancements/pull/5065

@bianbbc87 please confirm.

johnbelamaric avatar Feb 10 '25 20:02 johnbelamaric

@johnbelamaric

Hello ! I checked changed.

Please add #5065 under alpha kep of this pr and change it to alpha release target: 1.33.

Thank you !

bianbbc87 avatar Feb 10 '25 23:02 bianbbc87

Please add #5065 under alpha kep of this pr and change it to alpha release target: 1.33.

done

johnbelamaric avatar Feb 11 '25 15:02 johnbelamaric

Hi @johnbelamaric! :wave: v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

sreeram-venkitesh avatar Feb 15 '25 17:02 sreeram-venkitesh

Docs placeholder PR: https://github.com/kubernetes/website/pull/49869

mortent avatar Feb 23 '25 16:02 mortent