enhancements
enhancements copied to clipboard
Expose Node labels via downward API
Enhancement Description
- One-line enhancement description (can be used as a release note): Expose node labels via downward API
- Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4742-node-topology-downward-api/README.md
- Discussion Link:
- Primary contact (assignee): @andrewsykim @docandrew
- Responsible SIGs: sig-node
- Enhancement target (which target equals to which milestone):
- Alpha release target (x.y): 1.33
- Beta release target (x.y): 1.34
- Stable release target (x.y):
- [x] Alpha
- [x] KEP (
k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/5146 - [x] Code (
k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/127092 - [x] Docs (
k/website) update PR(s): https://github.com/kubernetes/website/pull/49928
- [x] KEP (
- [ ] Alpha refresh (fix label names)
- [ ] KEP (
k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/5428 - [ ] Code (
k/k) update PR(s): - [ ] Docs (
k/website) update(s):
- [ ] KEP (
Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
/sig node
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle rotten - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The existing PR was getting stale and not being updated. I opened https://github.com/kubernetes/enhancements/pull/5146 with the PRR sections filled out
/remove-lifecycle rotten
Given the sig-node approval for 1.33, I am milestoning and opting in (even though I am not a sig-node lead).
/label lead-opted-in /milestone v1.33
@dipesh-rawat another one that fell through the cracks, is this all set from sig release side?
@haircommander This one is interesting! The lead-opted-in was added kind of close to the deadline but didn't make it onto the board, possibly because the sync wasn't scheduled, and the job was disabled once we reached the deadline. Let me check if all the requirements for KEPs are in place, and if they are, we can manually add this one to the tracked board. If anything is missing, we may need to raise an exception.
Hello @andrewsykim @docandrew 👋, v1.33 Enhancements team here.
This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha
Here's where this enhancement currently stands:
- [x] KEP readme using the latest template has been merged into the k/enhancements repo.
- [x] KEP status is marked as
implementableforlatest-milestone: v1.33. KEPs targetingstablewill need to be marked asimplementedafter code PRs are merged and the feature gates are removed. - [x] KEP readme has up-to-date graduation criteria
- [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀
The status of this enhancement is marked as Tracked for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
/label tracked/yes
@haircommander Looks like this is all good for v1.33 release. For future, it might be helpful if we add the lead-opted-in label a bit earlier to allow time for the sync job and signal the intention to include a KEP in the release. This would also give the enhancements team more time to validate the KEP.
Absolutely thank you for your flexibility @dipesh-rawat ! We'll work on being more on top next time
Hello @haircommander :wave:, v1.33 Docs Lead here.
Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!
Hi @haircommander 👋 v1.33 Docs Lead here.
Gentle reminder! The deadline to raise a placeholder Docs PR is Thursday 27th February 2025 18:00 PDT. If this enhancement work requires any new docs or modification to existing docs, please create a placeholder PR (it can be a draft PR for now) before the deadline.
Thanks!
@rayandas https://github.com/kubernetes/website/pull/49928
@munnerz I hope you don't mind but I went ahead and opened the draft PR for the docs. Feel free to either take over with your own, or I don't mind doing the docs for this. I highlighted a quick preview of the existing documentation that needs to be updated, but will also need to add a new feature gate to the docs.
Thanks @dshebib
thank you very much @dshebib
Hi @andrewsykim @docandrew 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!
For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!
As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:
- This introduces some breaking change(s)
- This has significant impacts and/or implications to users
- ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉
To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚
[!Tip] Some timeline to keep in mind:
- 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
- Monday, 7th April, 2025: Feature blogs ready for review
- You can find more in the release document
[!Note] In your placeholder PR, use
XXcharacters for the blogdatein the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.
Hi @andrewsykim @docandrew 👋, 1.33 Communications Team here again!
This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!
[!Tip] Some timeline to keep in mind:
- 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
- Monday, 7th April, 2025: Feature blogs ready for review
- You can find more in the release document
[!Note] In your placeholder PR, use
XXcharacters for the blogdatein the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.
Hey again @docandrew 👋, v1.33 Enhancements team here,
Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.
Here's where this enhancement currently stands:
- [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
- [ ] All PRs are ready to be merged (they have
approvedandlgtmlabels applied) by the code freeze deadline. This includes tests.
For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):
- https://github.com/kubernetes/kubernetes/pull/127092
If you anticipate missing code freeze, you can file an exception request in advance.
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
The status of this enhancement is marked as At risk for code freeze.
As always, we are here to help if any questions come up. Thanks!
Hi @docandrew 👋, v1.33 Enhancements team here,
Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.
The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4742#issuecomment-2696317657 that still need to be completed.
If you anticipate missing code freeze, you can file an exception request in advance. Thank you!
Hello @docandrew 👋, v1.33 Enhancements team here.
With all the implementation (code-related) PRs merged per the issue description:
- https://github.com/kubernetes/kubernetes/pull/127092
This enhancement is now marked as Tracked for code freeze for the v1.33 Code Freeze!
Additionally, please let me know if there are any other PRs in k/k that we should track for this KEP, so that we can maintain accurate status.
Hi @andrewsykim @docandrew 👋, 1.34 Enhancements Lead here.
I am closing the v1.33 milestone now.
If you'd like to work on this enhancement in v1.34, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.34 using /milestone v1.34.
Thanks!
/remove-label lead-opted-in /remove-label tracked/yes /milestone clear
As per https://github.com/kubernetes/kubernetes/pull/127092#issuecomment-2898583878 we need to update the labels used for this feature to have a different suffix (we missed the use of .k8s.io rather than the .kubernetes.io 🤦♂️).
I am only just catching up with all this, I will target this change for v1.34 now given v1.33 is closed - I am not sure if it'd be eligible for a cherrypick given this is an alpha feature anyway?
As per kubernetes/kubernetes#127092 (comment) we need to update the labels used for this feature to have a different suffix (we missed the use of .k8s.io rather than the .kubernetes.io 🤦♂️).
I am only just catching up with all this, I will target this change for v1.34 now given v1.33 is closed - I am not sure if it'd be eligible for a cherrypick given this is an alpha feature anyway?
Features, especially alpha which are not that critical, are not eligible for cherry-picks. Renaming this while in alpha is perfectly reasonable and should be addressed before promoting to beta, and thus on by default.
Spoke to @andrewsykim. We want to aim for Beta in 1.34.
/label lead-opted-in /milestone v1.34
Spoke to @andrewsykim. We want to aim for Beta in 1.34.
Awesome. I suppose this includes fixing the default labels? see https://github.com/kubernetes/kubernetes/pull/127092#issuecomment-2898583878.
^^ @munnerz
yes, we'll have a KEP update out for that